From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755851AbcBXKaD (ORCPT ); Wed, 24 Feb 2016 05:30:03 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:35151 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbcBXK35 (ORCPT ); Wed, 24 Feb 2016 05:29:57 -0500 Message-ID: <1456309726.3396.31.camel@pengutronix.de> Subject: Re: [PATCH v2 0/3] drm: introduce bus_flags for pixel clock polarity From: Philipp Zabel To: Stefan Agner Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, airlied@linux.ie, daniel.vetter@ffwll.ch, jianwei.wang.chn@gmail.com, alison.wang@freescale.com, meng.yi@nxp.com, linux@arm.linux.org.uk, denis@eukrea.com, eric@eukrea.com, ville.syrjala@linux.intel.com, linux-kernel@vger.kernel.org, manfred.schlaegl@gmx.at, tomi.valkeinen@ti.com, boris.brezillon@free-electrons.com Date: Wed, 24 Feb 2016 11:28:46 +0100 In-Reply-To: <653e3f9d2d561a166a1768add0c59422@agner.ch> References: <1454968663-30066-1-git-send-email-stefan@agner.ch> <653e3f9d2d561a166a1768add0c59422@agner.ch> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 23.02.2016, 15:30 -0800 schrieb Stefan Agner: > Any comments on this? None other that I'm all in favor. consider patch 2 Acked-by: Philipp Zabel > Also added Manfred, Tomi and Boris to CC which previously attended in > similar discussions. > > Previous discussions: > http://thread.gmane.org/gmane.linux.kernel.api/12830 > http://thread.gmane.org/gmane.comp.video.dri.devel/96240/ > > I think one of the main observation so far was that the pixel clock > polarity is not a property of the mode, and therefor does not fit into > the DRM_MODE_FLAG. This has been pointed out nicely by Russel: > http://thread.gmane.org/gmane.comp.video.dri.devel/96240/focus=96260 > > Embedded displays connected through parallel bus make use of the > bus_formats field in drm_display_mode. This field defines what kind of > bus format the display requires. This patch follows that idea and adds > bus_flags. bus_flags can be used to define specific bus properties > required by the display, such as pixel clock or data enable polarity... regards Philipp