From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754643AbcBXLPW (ORCPT ); Wed, 24 Feb 2016 06:15:22 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35614 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbcBXLPS (ORCPT ); Wed, 24 Feb 2016 06:15:18 -0500 From: Sudip Mukherjee To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee , Peter Hurley Subject: [PATCH v2] tty: audit: remove unused variable Date: Wed, 24 Feb 2016 16:45:09 +0530 Message-Id: <1456312509-21904-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While building with W=1 we were getting build warning: drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used The local variable sessionid was only assigned the value of current->sessionid but was never reused. On further inspection it turned out that there is no need of audit_get_loginuid() also. Signed-off-by: Sudip Mukherjee --- v2: audit_get_loginuid() also removed. drivers/tty/tty_audit.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c index 66d53fc..df2d735 100644 --- a/drivers/tty/tty_audit.c +++ b/drivers/tty/tty_audit.c @@ -144,14 +144,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch) if (tty_audit_push()) return; - if (audit_enabled) { - kuid_t auid; - unsigned int sessionid; - - auid = audit_get_loginuid(current); - sessionid = audit_get_sessionid(current); + if (audit_enabled) tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1); - } } /** -- 1.9.1