From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758303AbcBYAKv (ORCPT ); Wed, 24 Feb 2016 19:10:51 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:47219 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbcBYAKt (ORCPT ); Wed, 24 Feb 2016 19:10:49 -0500 Message-ID: <1456349079.14487.20.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 08/67] af_unix: fix struct pid memory leak From: Ben Hutchings To: Rainer Weikusat , Willy Tarreau Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, "David S. Miller" , Eric Dumazet , Dmitry Vyukov Date: Wed, 24 Feb 2016 21:24:39 +0000 In-Reply-To: <87povnaxo5.fsf@doppelsaurus.mobileactivedefense.com> References: <87povnaxo5.fsf@doppelsaurus.mobileactivedefense.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Cb7f5HXMcJ1ThuZjFnI1" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:b06c:6b7a:5449:a1ad X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Cb7f5HXMcJ1ThuZjFnI1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-02-23 at 22:07 +0000, Rainer Weikusat wrote: > Ben Hutchings writes: > > 3.2.78-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas= e let me know. > >=20 > > ------------------ > >=20 > > From: Eric Dumazet > >=20 > > commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. >=20 > [...] >=20 > > Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix re= cv routines") >=20 > [...] >=20 > > =C2=A0net/unix/af_unix.c | 1 + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > --- a/net/unix/af_unix.c > > +++ b/net/unix/af_unix.c > > @@ -2100,6 +2100,7 @@ static int unix_stream_recvmsg(struct ki > > =C2=A0 > > =C2=A0 if (signal_pending(current)) { > > =C2=A0 err =3D sock_intr_errno(timeo); > > + scm_destroy(siocb->scm); > > =C2=A0 goto out; > > =C2=A0 } >=20 > JFTR: The commit mentioned in the fixes is (just the relevant part) [...] > This not only didn't add the block triggering the error but this change > isn't even part of the (version of) the function which was fixed > anymore. Yes, it looks like the bug was really introduced way back in 2.5.65 by "[NET]: Simplify scm handling and sendmsg/recvmsg invocation, consolidate net compat syscalls." So I think this is also needed for 2.6.32. Ben. --=20 Ben Hutchings Beware of programmers who carry screwdrivers. - Leonard Brandwein --=-Cb7f5HXMcJ1ThuZjFnI1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVs4fl+e/yOyVhhEJAQp7Hg/9FYRC3JQ2vES6KODv4buDlQ65G8XqpXiA 9GmAFxlXiPq/p/gON/FATKoNONjeq75AuUSwy+ORkkFaEf7bkGk1uTL/B4272HgS nwF0AXeko22gxGTQZCH3pMZRgDE77Ts/NJoyRsQ6OUesOlzUWZ3KAFoHeg8gTZ50 mLbkbHacgZK/rgPJJHJp81g+4McanNDJ7UuFKjhmlNi06ypprPVWS+/UHejPOWDZ f2UK/7+XcRM2Ye2lH3oe4lY5to3wI3ypdv36thR3FMLiKAnT/3hP3xWQ1KcJJqmn W3n4DUAjjs6u+ARAGDG/Ljuc8IwIXgpkxqt61eUIonDfQouj47Lj9TA1aMnxgDhd r0uZeUh1zi/oT9zSJn14EScj0qizJ7VGEYbrOgtd/gxzoH2lEEMb0xUl1aEnOGq8 sI3g+WDdmClkKA6aDt3z+5Tl4k4fDiud95etkcnOz3uq9b/bsaWrbsbOcelo30iW wXhwyVywQVPjZKG/hrWno2XjnJdZPJXQuoeydfOd+huQDRaPHauHWh14raqQPn5l mrYIidujdcJYeQ+J6hyQiVi8f4P77AICniZz1UWwT2DEDDSax3Ppc4/SVSg9stRu yZm7vrebs1tG4lBYkIIP+iINkvC/IR6zaJEZx3Ly4sNLhKiRtTcqKA3PyREEM+S8 etDmD40fLWM= =hRwE -----END PGP SIGNATURE----- --=-Cb7f5HXMcJ1ThuZjFnI1--