From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760021AbcBYHrd (ORCPT ); Thu, 25 Feb 2016 02:47:33 -0500 Received: from mail-by2on0084.outbound.protection.outlook.com ([207.46.100.84]:48005 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758745AbcBYHr1 convert rfc822-to-8bit (ORCPT ); Thu, 25 Feb 2016 02:47:27 -0500 Authentication-Results: spf=pass (sender IP is 204.128.141.24) smtp.mailfrom=infinera.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=bestguesspass action=none header.from=infinera.com; From: Joakim Tjernlund To: "dwmw2@infradead.org" , "Thomas.Betker@rohde-schwarz.com" CC: "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "sztomi89@gmail.com" , "wangzaiwei@top-vision.cn" , "deng.chao1@zte.com.cn" , "liu.ming50@gmail.com" , "dedekind1@gmail.com" , "viro@zeniv.linux.org.uk" , "linux-mtd-bounces@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "computersforpeace@gmail.com" Subject: Re: JFFS2 deadlock Thread-Topic: JFFS2 deadlock Thread-Index: AQHRWRjvZZoSrgnzGkiJVTVShkk9fJ8QDT2AgACGAoCAAIjyAIAGsWIAgBnldYuAC2JWAA== Date: Thu, 25 Feb 2016 07:46:20 +0000 Message-ID: <1456386428.3632.2.camel@infinera.com> References: <1453910781.20662.35.camel@infinera.com> <20160128000559.GA14270@google.com> <1454336914.133285.297.camel@infradead.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.100.99.93] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <6FA7532076B97A4A9F819518844EF5A5@infinera.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD053;1:yRcyWbRjGAD1FlPAO2K/owrP0sggbiz4QddCKAzL+usfN9ZKyGHGxt2oitX4PNFUY9P8BoLM17rte8ct+PGq9Rju62y2FYx3xE9Vh8CZ7Sa/gEnWN4bpzZxrwKNZpmcRFB/hO3zXG47AKdRWM5pgD210SPggKMqDmssRN3bVTRUwmWpvwtbSniefvuWBa2GUw6g70Sxp94D0h5ZN9tHnPKnWWAwUs4CeQyMhwz9+0cp+vgHUM+tt0fdu8MSFkZyuEfXqV6AaOSDsOJ3MRHdtiaTkHzVqI3gJlItPBta7FqXQkO2nJpOUzwhex/vOurXK5glhkDeCwhZu9MuxgtBw3vxlGNLoqN2J4NV3LhGTKV7WS8iJD73WIgkOletOFWoDlRukLSba36agBaeReip7k+49BLLljkdu+LA4wlBPKYE= X-Forefront-Antispam-Report: CIP:204.128.141.24;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377424004)(199003)(24454002)(189002)(19580395003)(19580405001)(10400500002)(5008740100001)(11100500001)(2950100001)(86362001)(2900100001)(5001770100001)(54356999)(50986999)(92566002)(103116003)(77096005)(15975445007)(6806005)(76176999)(47776003)(87936001)(93886004)(5004730100002)(4326007)(1096002)(1220700001)(6116002)(102836003)(33646002)(16796002)(586003)(106466001)(5001970100001)(2906002)(53416004)(106116001)(2501003)(36756003)(3846002)(189998001)(5003600100002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR10MB0435;H:sv-ex13-prd2.infinera.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: f65d0973-53f6-42f9-0b68-08d33db7e03d X-Microsoft-Exchange-Diagnostics: 1;BLUPR10MB0435;2:xanpS5qo3EjhuFbwPE5GaYkGNtUtUifP/ayzloz1buETMEU8HOEMVyQDl4qYHnvboGODlaiy4ymNSd6sGOfMCQesyOvtVib93OqQMgIeGOqrZv/JG0ODbSlhdLZEitNIoYG3zxzotWPwSbJNahlCOyYRHOX8g+3fqaBh0cmXqIGtLoL+lHRI7DmC5upAGpdb;3:tWeXhWMlZeDe8coBpCr1x9lRWvyIegBDATkXRpl0+kFpMoZC1pT/dnm2I9u3bG1nb0dSpPpnC88XCC1Esb70X1euv92RQe1LcDoHL6B5UfzNVgmA/qAHWg5A2sG5B1aFf/XZOdEsLUTdY1+LwCh+yHz2C54yQznMN1moAwCo+fORr6Y27RNdhKAWZHZ+XC2ti5D0R4lmVfkQQQ8QR/A6qBX55REiaxdsDk2h6nf5qAUyXhMaeCIJzqNedb/CqnmWnmHCmivlwy8GahPHla4+ig==;25:+jf9tT6iVIR8jln88VPJGZT0ewxUsDibzmxXShSHSEWMCdc+/WbTxLonWl9CE3JxTcmlhcMv59w+AGJnEwXMkO8LNpavt49wTEGx+hI73cYHL6RbzsHI0bLpq4vr2nc0z7kKx2TH0UmGMx6MspgY+U1eLvGXD4XQOComkHyAq1v+SpBCL3iTRxo5cWam5NoLtgIGpxNTx+eAjzcUg6F1NOoRXNkfZ33wwwtSZ8JzVdbF90NVrcwNltVrHh10e+rzK8IcyHXtYZgl3hzn1yRpJIYdTeUn2fEOOPJ3m25L2QzxJI6KriGDcbZByibPkNaft5kVj4Ytp9N6qNZJuCibwQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BLUPR10MB0435; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13018025)(8121501046)(13024025)(13023025)(5005006)(13017025)(10201501046)(3002001);SRVR:BLUPR10MB0435;BCL:0;PCL:0;RULEID:;SRVR:BLUPR10MB0435; X-Microsoft-Exchange-Diagnostics: 1;BLUPR10MB0435;4:FDx9TFtV+FJLpXZmkmwWot6fe9jiTSEtAnN+cKraegekQwhy066t4XdiVMypop/MnQOiuaapug1bceXAPpV5ebPetR5omJQaR2illVk9XdLTTtx8XmyUuq0JQKYC20d6APCi/5/o6NypcWNYHZNpRG3r9NO39d9pQJsXDpNaXJ2LVmZ1zg2i3SqLlk51eaCsjP4uunmLLw5c7+YXHxJtZs34BdNsoIUBSvMmAk9aIuCmRmAlX0f7kHWKudn2khU0KBSFGD8YdHoYikeLn0KG6juCsGNvMajD2S1p6leVX5HgA0ejdJ6pjjLTUDZtQDy8J+20ed/PdxIBgt4nnCPzt7BnsHm4wcx3ZXfxJkxMO2nKr/JrfxFS7FQnzhltl4GLowk5xgun+HIjP6GkxwYqrkP6D3mzEEsrPzQqWqFAs2z2rb4qlZCsFLJ2Ue9rIkLkaUESqrTZzxsMI5S26mWDag== X-Forefront-PRVS: 08635C03D4 X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BLUPR10MB0435;23:+Zgzh57rQgkPr937ofN1T9M2sjhpm9/mnNV5X0?= =?iso-8859-15?Q?SFPWOShFLYvf2B2OdMA0P0J70JVNwjMeu2iS6uwvaw/NqDcM8CuUxj+Bw?= =?iso-8859-15?Q?b/vROaTRpo4cUhq04Q4qQqkte8x4juHMb6WG7AEr2O11a00EKnOZkjzFg?= =?iso-8859-15?Q?4qVNH+JamI45kLTk6aCtawHbzFPGj76xnJ+ia7yr0YCssXFVEu8ADKsb5?= =?iso-8859-15?Q?w58WhAGD7KSAwod5LQiFWhaKV4f2z9u5TV85sscy/F7yS/U0oZ6YRJ5ZZ?= =?iso-8859-15?Q?UzdD8R9EXxBkYgjgckgLIKED3Cu8IwSi62pA7NvGShrURRWc/1ayNrIpA?= =?iso-8859-15?Q?O1v1jT0vvv2wehuwYUaumcnSZfB13rtI1DEgn5PRA9lcwog58DFXyAm70?= =?iso-8859-15?Q?hpQBIm8Jcvm+e8cO07KF9vBX7IBP5ziF8R25JVofFPQKS1EmoXKmtZDpW?= =?iso-8859-15?Q?5vhGlCWV4l8nBF+VLzqKWnXRhMuhtHazHj8G9oo/lm7H60HxEBIuPQ+Rc?= =?iso-8859-15?Q?sxpZ0wJayCzYE3lnBdLKAjcPepXe7ryLgs8OwUW+gsKHqo8nOUMy0+UxN?= =?iso-8859-15?Q?GWWdPcR2RN2Cra2R5bu9kyY1z0Tmxjo/e2k+woMix+2TpX8JWTtwD/Z4x?= =?iso-8859-15?Q?AI6cKrPj6klersCMgxkKsaqLnblBcYN1hFFDL7mNB7a4p8ZltGygWpe+z?= =?iso-8859-15?Q?2ymJ5oDrs+u37v3rjm9qrb2QRdvUVZwV+nTu//SBCr7LqJmXp1chq/OPl?= =?iso-8859-15?Q?YFi0liLglT8nZ3V/XyrLUG+Z0LnQEGaJ9+jlufKKJevD+XDOtD2i46o5/?= =?iso-8859-15?Q?Ze0H717RTFjdn78TmAXVh9wBXeUtvvepziwNulLKovxOYMhXPUSk/9/zN?= =?iso-8859-15?Q?OT4kX0ciTrD7+cgl6zJ+q2KvaaaFFxduBxTvT9VBRWk3rcCB29e9nmAdp?= =?iso-8859-15?Q?x5PptQFQNfK9Ny2IfBWayqfVIu0InsKB7z2L8JOlfOzoOryJ5ZDQugpea?= =?iso-8859-15?Q?ZahqtewXGiEqbipz4MMCuk+h1Lb5FaiPKrYUVm09HtU+Knh0jKL7WQXSx?= =?iso-8859-15?Q?F3CAT6qdIybbq4LmnKybL5wuLV60fXgWmnY4Lj4uGWFvbrdqNsl7Dp/9D?= =?iso-8859-15?Q?Cxe5CSskHFWPNjWNaWaHGklmzFXuS0qm8rnYJKY2dxVIayFxtByiAmMVe?= =?iso-8859-15?Q?q5ugPCz7HXyi3iAzneDYl5BvDq/5DokACIAc97uu2hae2n5xr/K0v6yxC?= =?iso-8859-15?Q?MZiQs78MOBP6BWmiTK5JA0C7avEgYe7UJGy9FS9s2+PHreY/R6dbmeQ1D?= =?iso-8859-15?Q?uNQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR10MB0435;5:i1J+us1hz2Eefm3q1crY5gviC1YPM6ahyIcaM0YVWss7a/Nxn0W8hPO16G2UPn7PVYEUmtZMD1pjfdlUgdgaUXp3/8sEuqIdPMF9jmQROhN7+spmQC9S42I+WJNDLkjrc9a7/9YKWdWsWVsrPn9+xg==;24:YiGqknchBIg5Knb2/0H+i12kXhcwcLCfsGL9lAqKL5IAvkXa5GaeorFN/PM/NDJ/PLsmAsi0RLwQMJmbQ6pbox7VtHX08VHeE64ECWbCfg0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2016 07:47:13.9154 (UTC) X-MS-Exchange-CrossTenant-Id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;Ip=[204.128.141.24];Helo=[sv-ex13-prd2.infinera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR10MB0435 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-18 at 10:57 +0100, Thomas.Betker@rohde-schwarz.com wrote: > Hello David: > > > > > > > > > Please could you try what's in the tree at > > > http://git.infradead.org/users/dwmw2/jffs2-fixes.git > > > > Your patch looks much simpler, and I will definitely test it. It may > > take a few days, though, as I have to unearth the test scripts, and  > > find a time slot for testing. > Here is what I did (sorry for the wait, things were piling up): > > 1) Removed Deng Chao's patch from my kernel, added your patch "jffs2: Fix  > page lock / f->sem deadlock". I am still on linux-3.14, but jffs2 hasn't  > changed much since then, so this shouldn't make a difference. Added a  > printk() before mutex_unlock(&f->sem) to check if the prospective page was  > locked, i.e. if the deadlock situation actually occurs. > > 2) On my target system, started wangzaiwei's test (with some fixes), plus  > a loop copying a large file over and over (to get GC rolling, which  > increases the chance of a deadlock). > > 3) After 24 hours, the system was still alive, and the printk() had been  > hit 32 times. > > So yes, I am confident that your patch avoids the deadlock, and if that's  > good enough for you, please add my Tested-by:. However, I am going to run  > some more stress tests here just to check that there weren't any  > unexpected side effects. (Don't get me wrong -- I am sure the patch is  > fine, but for me it's a case of "once bitten, twice shy" ...) Can we get this upstream before next release? I don't think there will much more testing at this point.  Jocke