From: John Garry <john.garry@huawei.com>
To: <JBottomley@odin.com>, <martin.petersen@oracle.com>
Cc: <linuxarm@huawei.com>, <john.garry2@mail.dcu.ie>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
John Garry <john.garry@huawei.com>
Subject: [PATCH v2 3/6] hisi_sas: use slot abort in v1 hw
Date: Thu, 25 Feb 2016 17:42:12 +0800 [thread overview]
Message-ID: <1456393335-38294-4-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1456393335-38294-1-git-send-email-john.garry@huawei.com>
When TRANS_TX_CREDIT_TIMEOUT_ERR or
TRANS_TX_CLOSE_NORMAL_ERR error occur in
a slot, the command should be re-attempted.
This error is equivalent to meaning that the queue
is full in the sdev (and not the host).
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index ce5f65d..1abbc2e 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1212,6 +1212,14 @@ static void slot_err_v1_hw(struct hisi_hba *hisi_hba,
ts->stat = SAS_NAK_R_ERR;
break;
}
+ case TRANS_TX_CREDIT_TIMEOUT_ERR:
+ case TRANS_TX_CLOSE_NORMAL_ERR:
+ {
+ /* This will request a retry */
+ ts->stat = SAS_QUEUE_FULL;
+ slot->abort = 1;
+ break;
+ }
default:
{
ts->stat = SAM_STAT_CHECK_CONDITION;
@@ -1319,6 +1327,11 @@ static int slot_complete_v1_hw(struct hisi_hba *hisi_hba,
!(cmplt_hdr_data & CMPLT_HDR_RSPNS_XFRD_MSK)) {
slot_err_v1_hw(hisi_hba, task, slot);
+ if (unlikely(slot->abort)) {
+ queue_work(hisi_hba->wq, &slot->abort_slot);
+ /* immediately return and do not complete */
+ return ts->stat;
+ }
goto out;
}
--
1.9.1
next prev parent reply other threads:[~2016-02-25 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 9:42 [PATCH v2 0/6] hisi_sas: add abort and retry feature John Garry
2016-02-25 9:42 ` [PATCH v2 1/6] hisi_sas: change tmf func complete check John Garry
2016-02-27 11:56 ` Hannes Reinecke
2016-02-25 9:42 ` [PATCH v2 2/6] hisi_sas: add hisi_sas_slot_abort() John Garry
2016-02-27 11:57 ` Hannes Reinecke
2016-02-25 9:42 ` John Garry [this message]
2016-02-27 11:58 ` [PATCH v2 3/6] hisi_sas: use slot abort in v1 hw Hannes Reinecke
2016-02-25 9:42 ` [PATCH v2 4/6] hisi_sas: use slot abort in v2 hw John Garry
2016-02-27 11:59 ` Hannes Reinecke
2016-02-25 9:42 ` [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure() John Garry
2016-02-27 11:59 ` Hannes Reinecke
2016-02-25 9:42 ` [PATCH v2 6/6] hisi_sas: update driver version to 1.3 John Garry
2016-02-27 12:00 ` Hannes Reinecke
2016-03-01 2:00 ` [PATCH v2 0/6] hisi_sas: add abort and retry feature Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456393335-38294-4-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=JBottomley@odin.com \
--cc=john.garry2@mail.dcu.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®