From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760875AbcBYO4Q (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 09:56:16 -0500
Received: from mga11.intel.com ([192.55.52.93]:55948 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1760300AbcBYO4P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 09:56:15 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; 
   d="scan'208";a="923768749"
Message-ID: <1456412171.11136.11.camel@tzanussi-mobl.amr.corp.intel.com>
Subject: Re: [PATCH] kselftests/ftrace: Add a test for log2 modifier of hist
 trigger
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Date: Thu, 25 Feb 2016 08:56:11 -0600
In-Reply-To: <20160225091921.3192.21916.stgit@localhost.localdomain>
References: <cover.1456333190.git.tom.zanussi@linux.intel.com>
	 <20160225091921.3192.21916.stgit@localhost.localdomain>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Masami,

On Thu, 2016-02-25 at 18:19 +0900, Masami Hiramatsu wrote:
> Add a test for log2 modifier of hist trigger in hist_mod.tc.
> Here is the test result.
> 
>   ----
>   # ./ftracetest test.d/trigger/trigger-hist-mod.tc
>   === Ftrace unit tests ===
>   [1] event trigger - test histogram modifiers	[PASS]
> 
>   # of passed:  1
>   # of failed:  0
>   # of unresolved:  0
>   # of untested:  0
>   # of unsupported:  0
>   # of xfailed:  0
>   # of undefined(test bug):  0
>   ----
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> 
> Hi Tom, here is the patch to add a test for log2 modifier on your branch.
> 

Thanks!  I'll add it to my branch.

Tom

> Thanks,
> ---
>  .../ftrace/test.d/trigger/trigger-hist-mod.tc      |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc
> index 57e350a..c2b61c4 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc
> @@ -60,6 +60,16 @@ for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
>  grep "id: sys_" events/raw_syscalls/sys_exit/hist > /dev/null || \
>      fail "syscall modifier on raw_syscalls/sys_exit did not work"
>  
> +
> +reset_trigger
> +
> +echo "Test histgram with log2 modifier"
> +
> +echo 'hist:keys=bytes_req.log2' > events/kmem/kmalloc/trigger
> +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
> +grep 'bytes_req: ~ 2^[0-9]*' events/kmem/kmalloc/hist > /dev/null || \
> +    fail "log2 modifier on kmem/kmalloc did not work"
> +
>  do_reset
>  
>  exit 0
> 
>