From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: konrad.wilk@oracle.com, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
mcgrof@kernel.org, brgerst@gmail.com, andrew.cooper3@citrix.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
stable@vger.kernel.org
Subject: [PATCH v3 1/2] xen/x86: Zero out .bss for PV guests
Date: Thu, 25 Feb 2016 10:16:34 -0500 [thread overview]
Message-ID: <1456413395-7679-2-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1456413395-7679-1-git-send-email-boris.ostrovsky@oracle.com>
Baremetal kernels clear .bss early in the boot but Xen PV guests don't
execute that code. They have been able to run without problems because
Xen domain builder happens to give out zeroed pages. However, since this
is not really guaranteed, .bss should be explicitly cleared.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: stable@vger.kernel.org
---
arch/x86/xen/xen-head.S | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index b65f59a..11dbe49 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -38,6 +38,20 @@
__INIT
ENTRY(startup_xen)
cld
+
+#ifdef CONFIG_X86_32
+#define WSIZE_SHIFT 2
+#else
+#define WSIZE_SHIFT 3
+#endif
+ /* Clear .bss */
+ xor %eax,%eax
+ mov $__bss_start, %__ASM_REG(di)
+ mov $__bss_stop, %__ASM_REG(cx)
+ sub %__ASM_REG(di), %__ASM_REG(cx)
+ shr $WSIZE_SHIFT, %__ASM_REG(cx)
+ rep __ASM_SIZE(stos)
+
#ifdef CONFIG_X86_32
mov %esi,xen_start_info
mov $init_thread_union+THREAD_SIZE,%esp
--
2.1.0
next prev parent reply other threads:[~2016-02-25 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 15:16 [PATCH v3 0/2] Clear .bss for VP guests Boris Ostrovsky
2016-02-25 15:16 ` Boris Ostrovsky [this message]
2016-02-25 16:12 ` [PATCH v3 1/2] xen/x86: Zero out .bss for PV guests Brian Gerst
2016-02-25 15:16 ` [PATCH v3 2/2] xen/x86: Drop mode-selecting ifdefs in startup_xen() Boris Ostrovsky
2016-02-26 10:53 ` [Xen-devel] [PATCH v3 0/2] Clear .bss for VP guests Roger Pau Monné
2016-02-26 13:51 ` Boris Ostrovsky
2016-02-26 14:42 ` Brian Gerst
2016-02-26 15:10 ` Boris Ostrovsky
2016-02-26 15:12 ` David Vrabel
2016-02-26 15:22 ` Roger Pau Monné
2016-02-26 15:26 ` David Vrabel
2016-02-26 15:38 ` Boris Ostrovsky
2016-02-26 15:30 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456413395-7679-2-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=brgerst@gmail.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®