From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760967AbcBYR1w (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 12:27:52 -0500
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34763 "EHLO
	metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758976AbcBYR1v (ORCPT
	<rfc822;linux-kernel@vger.kernel.Org>);
	Thu, 25 Feb 2016 12:27:51 -0500
Message-ID: <1456421257.3268.18.camel@pengutronix.de>
Subject: Re: [PATCH v2] mfd: syscon: allow to register syscon with a device
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>, Alexander Shiyan <shc_work@mail.ru>,
        Pankaj Dubey <pankaj.dubey@samsung.com>,
        Pawel Moll <pawel.moll@arm.com>, Wolfram Sang <wsa@the-dreams.de>,
        Peter Seiderer <ps.report@gmx.net>,
        Tushar Behera <tushar.behera@linaro.org>, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Date: Thu, 25 Feb 2016 18:27:37 +0100
In-Reply-To: <2637460.3ZCmmf9MXm@wuerfel>
References: <1456312741-7658-1-git-send-email-p.zabel@pengutronix.de>
	 <2970085.kbMT7OBsMB@wuerfel> <1456326148.3396.43.camel@pengutronix.de>
	 <2637460.3ZCmmf9MXm@wuerfel>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

Am Mittwoch, den 24.02.2016, 17:26 +0100 schrieb Arnd Bergmann:
> On Wednesday 24 February 2016 16:02:28 Philipp Zabel wrote:
> > > > @@ -473,6 +474,12 @@ static const struct of_device_id imx6q_pinctrl_of_match[] = {
> > > >  
> > > >  static int imx6q_pinctrl_probe(struct platform_device *pdev)
> > > >  {
> > > > +       struct device_node *syscon_np;
> > > > +
> > > > +       syscon_np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-iomuxc-gpr");
> > > > +       if (syscon_np)
> > > > +               syscon_register(&pdev->dev, syscon_np);
> > > > +
> > > >         return imx_pinctrl_probe(pdev, &imx6q_pinctrl_info);
> > > >  }
> > > >  
> > > > The pinctrl driver is probed at arch_initcall time.
> > > 
> > > I still don't see it where you are getting with this. Is this just for
> > > the debugfs interface or is there something else this does on top of
> > > that?
> > 
> > Sorry, yes, this is about the missing debugfs functionality.
> 
> Ok, so maybe there is a different way of doing this: If I understood
> it correctly, we now lost the debugfs handling on all syscon nodes?
> 
> Should we try to come up with a way to bring it back for all of them
> then, rather than having to do it per device?
> 
> I can see two possible ways of doing that:
> 
> a) change the regmap code to provide a debugfs interface for all
>    regmaps, including those without a device
> b) change the syscon driver to explicitly register the debugfs
>    interface at a later point in boot when the devices become
>    available

Thanks, b) seems to fit well for the i.MX IOMUXC. I have sent a patch to
use regmap_attach_dev for that.

regards
Philipp