From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: Alex Ng <alexng@microsoft.com>, "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 6/8] Drivers: hv: utils: Remove util transport handler from list if registration fails
Date: Fri, 26 Feb 2016 15:13:20 -0800 [thread overview]
Message-ID: <1456528402-21982-6-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1456528402-21982-1-git-send-email-kys@microsoft.com>
From: Alex Ng <alexng@microsoft.com>
If util transport fails to initialize for any reason, the list of transport
handlers may become corrupted due to freeing the transport handler without
removing it from the list. Fix this by cleaning it up from the list.
Signed-off-by: Alex Ng <alexng@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv_utils_transport.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index 4f42c0e..9a9983f 100644
--- a/drivers/hv/hv_utils_transport.c
+++ b/drivers/hv/hv_utils_transport.c
@@ -310,6 +310,9 @@ struct hvutil_transport *hvutil_transport_init(const char *name,
return hvt;
err_free_hvt:
+ spin_lock(&hvt_list_lock);
+ list_del(&hvt->list);
+ spin_unlock(&hvt_list_lock);
kfree(hvt);
return NULL;
}
--
1.7.4.1
next prev parent reply other threads:[~2016-02-26 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 23:13 [PATCH 0/8] Drivers: hv: Miscellaneous fixes K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 1/8] Drivers: hv: vmbus: don't loose HVMSG_TIMER_EXPIRED messages K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 2/8] Drivers: hv: vmbus: avoid wait_for_completion() on crash K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 3/8] Drivers: hv: vmbus: remove code duplication in message handling K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 4/8] Drivers: hv: vmbus: avoid unneeded compiler optimizations in vmbus_wait_for_unload() K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 5/8] Drivers: hv: util: Pass the channel information during the init call K. Y. Srinivasan
2016-02-26 23:13 ` K. Y. Srinivasan [this message]
2016-02-26 23:13 ` [PATCH 7/8] Drivers: hv: vmbus: Support handling messages on multiple CPUs K. Y. Srinivasan
2016-02-26 23:13 ` [PATCH 8/8] Drivers: hv: vmbus: Support kexec on ws2012 r2 and above K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456528402-21982-6-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=alexng@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®