From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756540AbcB0MDr (ORCPT ); Sat, 27 Feb 2016 07:03:47 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34066 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756367AbcB0MDq (ORCPT ); Sat, 27 Feb 2016 07:03:46 -0500 From: Sudip Mukherjee To: Lidza Louina , Mark Hounschell , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 1/4] staging: dgnc: remove unneeded else Date: Sat, 27 Feb 2016 17:33:32 +0530 Message-Id: <1456574615-32003-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If pci_enable_device() fails then we can return directly. Signed-off-by: Sudip Mukherjee --- I saw there is some pending dgnc patch in outreachy, so this series might not apply. This series is based on staging-testing. I will resend v2 if it fails. drivers/staging/dgnc/dgnc_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index fc6d298..c32f208 100644 --- a/drivers/staging/dgnc/dgnc_driver.c +++ b/drivers/staging/dgnc/dgnc_driver.c @@ -283,13 +283,13 @@ static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) /* wake up and enable device */ rc = pci_enable_device(pdev); - if (rc < 0) { - rc = -EIO; - } else { - rc = dgnc_found_board(pdev, ent->driver_data); - if (rc == 0) - dgnc_NumBoards++; - } + if (rc) + return -EIO; + + rc = dgnc_found_board(pdev, ent->driver_data); + if (rc == 0) + dgnc_NumBoards++; + return rc; } -- 1.9.1