From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992453AbcB0Mpm (ORCPT ); Sat, 27 Feb 2016 07:45:42 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60311 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756331AbcB0Mpl (ORCPT ); Sat, 27 Feb 2016 07:45:41 -0500 From: Colin King To: Herbert Xu , "David S . Miller" , David Howells , James Morris , Tadeusz Struk , Peter Jones , linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] PKCS#7: fix unitialized boolean 'want' Date: Sat, 27 Feb 2016 12:45:26 +0000 Message-Id: <1456577126-5351-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 2.7.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The boolean want is not initialized and hence garbage. The default should be false (later it is only set to true on tne sinfo->authattrs check). Found with static analysis using CoverityScan Signed-off-by: Colin Ian King --- crypto/asymmetric_keys/pkcs7_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c index 8f3056c..7a24e16 100644 --- a/crypto/asymmetric_keys/pkcs7_parser.c +++ b/crypto/asymmetric_keys/pkcs7_parser.c @@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message); static int pkcs7_check_authattrs(struct pkcs7_message *msg) { struct pkcs7_signed_info *sinfo; - bool want; + bool want = false; sinfo = msg->signed_infos; if (sinfo->authattrs) { -- 2.7.0