From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992662AbcB0XW0 (ORCPT ); Sat, 27 Feb 2016 18:22:26 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:44139 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992461AbcB0XWY (ORCPT ); Sat, 27 Feb 2016 18:22:24 -0500 Message-ID: <1456615342.1750.49.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] configfs: switch ->default groups to a linked list From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: jlbec@evilplan.org, balbi@kernel.org, laurent.pinchart@ideasonboard.com, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Date: Sat, 27 Feb 2016 15:22:22 -0800 In-Reply-To: <1456490031-7132-1-git-send-email-hch@lst.de> References: <1456490031-7132-1-git-send-email-hch@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-02-26 at 13:33 +0100, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're at it also provide a conveniant helper to remove the default > groups. > > Signed-off-by: Christoph Hellwig > --- > Documentation/filesystems/configfs/configfs.txt | 11 +- > drivers/infiniband/core/cma_configfs.c | 31 ++-- > drivers/target/iscsi/iscsi_target_configfs.c | 75 +++------ > drivers/target/target_core_configfs.c | 203 +++++------------------- > drivers/target/target_core_fabric_configfs.c | 194 ++++++---------------- > drivers/target/target_core_internal.h | 1 - > drivers/target/target_core_stat.c | 41 ++--- > drivers/usb/gadget/configfs.c | 36 ++--- > drivers/usb/gadget/function/f_mass_storage.c | 6 +- > drivers/usb/gadget/function/f_rndis.c | 1 - > drivers/usb/gadget/function/uvc_configfs.c | 198 +++++++++-------------- > fs/configfs/dir.c | 44 +++-- > fs/configfs/item.c | 1 + > fs/dlm/config.c | 38 +---- > fs/ocfs2/cluster/nodemanager.c | 22 +-- > include/linux/configfs.h | 11 +- > include/target/target_core_base.h | 3 - > 17 files changed, 284 insertions(+), 632 deletions(-) > This is a very nice simplification to drop the long-standing fixed size ->default_groups[] usage tree-wide for configfs consumers. For the target parts: Acked-by: Nicholas Bellinger Also, this applies cleanly to target-pending/for-next, so I don't see a problem merging it up via your new configfs tree. Otherwise let me know, and I'll be happy to merge via target-pending. Thanks HCH.