From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbcB1V7S (ORCPT ); Sun, 28 Feb 2016 16:59:18 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:50717 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755040AbcB1V7Q (ORCPT ); Sun, 28 Feb 2016 16:59:16 -0500 From: Arnd Bergmann To: Joonsoo Kim , linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org, Michal Nazarewicz , Steven Rostedt , Andrew Morton , Arnd Bergmann , Dan Williams , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit Date: Sun, 28 Feb 2016 22:57:23 +0100 Message-Id: <1456696663-2340682-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:xRjVYpTqKma33zZA3fM6i5FZe3pFuicvo8IxQEpQUE8/O6SAvpO JT+dvM5eZ4w5sd98Jd6jQPOHXZBh2PtoMocU/bQ/+R2C1AH1MSFzZokYa22e5u+XdXCiFOg wx1d3YeLsUMIMdYpNgvRBQ0QjP9E5HwagIeIYzsXjUdeMOgduc6w9d3FOgWWkbkRszjo3Cr kL9IyCcTPY/2lO9GwofWw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0kuKE+iS0Hg=:D62eWfM9JwiKhEHzFTjDyx JtpffhVa4bQfsl+6Rm65hfUPwMOWPZQ5ubbCGCKnnsciJM7rcNUFq7Nm7vm3IexaxXKb4fAk4 mpUZPUcySwxiR+0u5atdHH6rkLbeYniJYWvaOPNkU6lUg2uT4++yB5yOOho57pxZ7ivT/NHvM dRvalNReDT1Q06nqT26F05p1smFpLg3RSiqBlAAN9RMxgdsJu33H3A9vOaFbOEHFh1AEp1mxo HK9hT1cn4JReRdUmXnSoTo7XczS5kH4l8vrqH7G8Xp7D83cuHu/DmsFPpm7kpFUXJxy738Q+P 5FnKo4M3J6rqkKrrpUbzcObjCa/ML+uLqboO0o574EnAUMo/+RLWaL8IFxlTSMoLcmGcTx8Ap rmmZrWDRaHjaA6RW1n/qwJhZqdgLXe15lfic8SumXzk/wXRFNH6JusSbJ9+x+QwtE6mtkaOo/ v0xJx8JleIE2OBT96HazlEY8a9ehNg9sAfWI1B5/ffMgQ/Q4YWrQ0ZKWMGUCdeb1804QIix30 NT9qY1/oXwQTQIrFb5rst8Hh3ZnIarAT8w3GySUwN8v/On/tgD3cf/vT+/y5L1W+2fKo6kJV5 qJ6c+Mx0k9TS3GaPWLjplRkvVuoswKKaQ5++owMAmm7k14GylcJZ4Tl7B60ZRrkdZokJBj1fp d4Ryy0KDwq9dsU7ngNifvj42A1OImzlGNueEERhbWPkcEbBTVGfJdkOyPFWidxWBvDwo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The addition of tracepoints to the page reference tracking had an unfortunate side-effect in at least one driver that calls put_page from its exit function, resulting in a link error: `.exit.text' referenced in section `__jump_table' of crypto/built-in.o: defined in discarded section `.exit.text' of crypto/built-in.o I could not come up with a nice solution that ignores __jump_table entries in discarded code, so we probably now have to treat this as something a driver is not allowed to do. Removing the __exit annotation avoids the problem in this particular driver, but the same problem could come back any time in other code. On a related problem regarding the runtime patching for SMP operations on ARM uniprocessor systems, we resorted to not drop the .exit section at link time, but that doesn't seem appropriate here. Signed-off-by: Arnd Bergmann Fixes: 0f80830dd044 ("mm/page_ref: add tracepoint to track down page reference manipulation") --- crypto/async_tx/async_pq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/async_tx/async_pq.c b/crypto/async_tx/async_pq.c index c0748bbd4c08..be167145aa55 100644 --- a/crypto/async_tx/async_pq.c +++ b/crypto/async_tx/async_pq.c @@ -442,7 +442,7 @@ static int __init async_pq_init(void) return -ENOMEM; } -static void __exit async_pq_exit(void) +static void async_pq_exit(void) { put_page(pq_scribble_page); } -- 2.7.0