From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753221AbcCAAON (ORCPT ); Mon, 29 Feb 2016 19:14:13 -0500 Received: from mail-am1on0072.outbound.protection.outlook.com ([157.56.112.72]:51201 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750832AbcCAAOJ (ORCPT ); Mon, 29 Feb 2016 19:14:09 -0500 X-Greylist: delayed 7121 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Feb 2016 19:14:08 EST Authentication-Results: spf=fail (sender IP is 12.216.194.146) smtp.mailfrom=ezchip.com; ezchip.com; dkim=none (message not signed) header.d=none;ezchip.com; dmarc=none action=none header.from=ezchip.com; From: Chris Metcalf To: Russell King , Thomas Gleixner , Aaron Tomlin , Ingo Molnar , Andrew Morton , Daniel Thompson , , CC: Chris Metcalf Subject: [PATCH 3/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Date: Mon, 29 Feb 2016 16:40:23 -0500 Message-ID: <1456782024-7122-4-git-send-email-cmetcalf@ezchip.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1456782024-7122-1-git-send-email-cmetcalf@ezchip.com> References: <1456782024-7122-1-git-send-email-cmetcalf@ezchip.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:12.216.194.146;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(48376002)(4001430100002)(50466002)(33646002)(2906002)(2950100001)(4326007)(189998001)(92566002)(5001970100001)(107886002)(5003940100001)(105606002)(87936001)(85426001)(42186005)(229853001)(81156008)(19580405001)(106466001)(19580395003)(47776003)(586003)(36756003)(76176999)(50986999)(50226001)(2201001)(6806005)(104016004)(1220700001)(1096002)(5001770100001)(5008740100001)(42882005)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR05MB421;H:lab-41.internal.tilera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD035;1:nKJZxtBFjhOrbv+M1Bo+lECXkCKi2N/GzhnUOQhR5Q3Qetu7B80uaxlLBbV+IDL7CWw66m9f3b7P6GcgwRD6PH3pU/tOjA+40XaaIFEuyBbIVgY43I+9roU3u6yWWC4cDOoCQ5uYqc6MaDeLfG1zZq0e8/IdkQIy17pkWyIAj/INEXQ5KuCjXK4kaUM7q6eYlBmceI0fwMsdzZ2tj+khf1wmo64X2ZOUxQ6LzoK6emhNb75DV5O987qHEzr3m6KV/L+CfHnaE/V6pZoArfh2ruPDztq6nczWWTPvxETVYVzFCIjld0DuPorq7xuVF551R5Un5Rao/fUOtOn1twy3ik46rA/AouBQd0Z0xHVkKf11Jcu8LqRlIWc+3nH9ZO9xgwntSZo77aozv/zguY2CAM9kILakvciXGmS1tB27xcVLUsqVxaEL1ifN2JTrPvENXEKfaRPgCEGULwCcA2nTxCEf6Kw3bHG8sXeaQGJncpGoYI7EYl6sJrIeJQhZeylqjRXIt+31wb4KXQ3iqPSPVg== MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB421;2:ATUFcQJ/u79GSceXVFofQQEKSFGqkkt8fkJnwWhaxf8ZWoZtvuUJRdaQD4AxMDRCib85xNL9eWOmYZUO/DcpHUub2icsE3A1zUvaNAB+g8zXOlswBxiUq1ul+4dnoyNXZw6kCg2a2loCzu/IuCrimQ==;3:RU9Bf0EbxGbIRAUL9swwfQX3YmYDNicWbYzmAbYQrPc8quu6Hu0oSXmQdbkR4iiKEduVO4JaOtVCGkDgyAhhCJf+fHEo/rwvnumqS5du9J5Lnrebm2eOE57/lsh/PklXObY3hxeKRd+k0NjKv1YD6vzZsjNFpLuMywsU/S0eJQM=;25:2hFMqZ2lvOGbOkOjiKf4cey8Y6I36Ry5b0rgOgalvuNAvGqbUP/qiZlQlKV9V5QNrss9C33LmvKhj1Qr7aiJuIr9wZf12GOjMd+I7JdBG4PSMHgd1jXuMt1iVzR57krn2DYSI6G3pLcWtoJbVxrNZxPgdYiNQxCBzrCdX9x9KS6j1Ym4YJFl8yPK9CgGpDsRUWP7yUCW4KS0nWiGjnHNm3oScTrPzU03cGnRmLtNYSLaU2eZW4Vyu/WTp64gRsDFFYehcNMXuD1CBZDc9HtFGtqpFUJBA55uheRgcscgy142lRDkT11nbaUtYUIh7bmkJvrMdC8FHTnZaDKs5pwTEg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB421; X-MS-Office365-Filtering-Correlation-Id: 3a631695-84a5-409b-8f96-08d34150fb82 X-MLNXRule-EZCH-Linux: Rule triggered X-MLNXRule-Acc-Dom-4: Rule triggered X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB421;20:YAGuRYMjTjVo/acDW6OsMy7gra7efylGigjDtZP7ofoaIM/jdO9rIV33ODvvy5ScrcajKSVOZ72/clRD9HTrX1xDGsRLbUQLub9lNH5UmLupRWEbHNtRs1SUAyzOQjHcF5YnIo0t7JQUpLStlmu5oBVuDgbcjg9t+w4JFKmbd3NHsfWY/XM3rklDuHEEnUOBZ5se3ETr2Khr+KzEmHZ54x9DGmVRDV3g9lSukoCL+ecsocYFGRiUd8W6xPnqkiiBRFO7pYtdrRFz4ZCueR2KbDac0hJ//jx8UY7LDGFlYmAaHBJS6XEagALgv8O38qBRF4xcuiw7Y+tnZ5WeiY2v0Zp8gJ89hYgmSsN6GFsJ2N9NhAwh20wUQ1Ry8Wlraj3etZyCHsQfZyvZUImad0DmD1pSjcrsBOxmo6QusnCyBPirEHCq546xA5KLAW+a3ybmGZOSFz4Mj/3NHE6al8RaKTs8bqsten07v52db3Ui46+s4730OTd1wnsAqD5cUNT3fC0A7xiApBafcROUhX3Zjy1JMu1kUR5FJzMqNGSGuonFUC3Y1WscBGG9OHAnzkrm3fFyfgUm+C37jFNCIDN1DoDyuAQUXsRscF01hg+6HXg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(5005006)(13023025)(13015025)(13018025)(13024025)(8121501046)(3002001)(10201501046);SRVR:AMSPR05MB421;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB421; X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB421;4:oF3pH9jpZzSkLhtIqcC3A/OquAQlP61x4yL4kjHL9/9xKz+7+bRzV7/2LrLpAgmgeC+zDTXnGZaJY5uVX5LCh43xCENmWLxDX/QRqiI0/wmDVwmq4gfCOOpMTX8sX1/Ylewt4o/MPQyeBT/X8cOU8Bv93slAsXYlbw8tFFgTJxo6lpMATN4uekv++P0C6JHRItUBRwQvMr7l2D0WmxO0e8ofDLu5aiggNGdk1Fb6DnpM85BGZpQrA4SWgOJTUK6Fbavv0jTldSgnYez91qftiEDAT0weHQgibwqtEylHyDmfSb37WENCU1mmh1wA4HH+EYw74jrjlSiXmeq6tZyOawf0NUMpoRvYB49jIgWwWi2egPJ+8peACBIVDkEpdgPEXTw9EBNkSIk5WzePFz7fualBjPgeFywA/OJEZh+IQNw1k7K/TmtWFPxlqTErjiApJmYouP87uloARtuEX2l3qQ== X-Forefront-PRVS: 0867F4F1AA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AMSPR05MB421;23:U1qYhiyC+VvMkNC09UZUbOR3DZWcqNNKWJbbr5DFXd?= =?us-ascii?Q?Pe1PlWDSrGjvSbfKuj8l+e88NyHufBj3zN2fu0ZuKGySebToSIR7CDJSwlim?= =?us-ascii?Q?pfm9//fEzImjYTn7PWz4PEsnScD/OSUi+OBuQWjyCHozuAC3aivZeOIuty+P?= =?us-ascii?Q?j0Yy95+qC+7E8NCjm1iqpFISl4FOgW7rgFJKXK7ymdhmMQCJk/YpB2T2r/F6?= =?us-ascii?Q?H1tRBK1CUBP+Lz3ScrsL/WmcvSqFbbpF+sbM7j1NvTSEmOG7gsf9ILQitRu/?= =?us-ascii?Q?cG7wsNNqOCXZyPaJQvQlbTjVZC9cLhh1urSNzOcygSNCsZ+0G65bg10nRKi0?= =?us-ascii?Q?JEpJJBTtAC+rI14rUggNO/0wthw9HYdvmXCUtYCshZfDdwXFI+r0rTgm8eSO?= =?us-ascii?Q?msL1/CT3o0Cyt8Kj22PqfkPiuUS1bcJew5bb71daZREhDbZFpcmabddLVCOI?= =?us-ascii?Q?zyYPB4WUaiL4a2sLI8100x31vnYI9YYMNtlaYntT4FfGJz8ZO1hgI4OGmBlo?= =?us-ascii?Q?x0ziC+RjgNtRawD1xoiIFmZ2mqWZ2C7aMo5C2eqPdoE7/nuG5JE8HffvS8k5?= =?us-ascii?Q?gPMx7NSsSudCTnLnyV/ATjBZ58SjFHuIaHmUiuRE6lylciGVX/t/tXPFlzyo?= =?us-ascii?Q?4DBzbRiL133isNH1cNBLvXa6CJ+YV0XalaXT7kRPowBsffDxj1zNcykUchu1?= =?us-ascii?Q?1Xsfd9laCUA00XXcyQkj5rkAPIch6TBFk4Dvrs9/GbONCW446II4p8XpeVrP?= =?us-ascii?Q?qqTt8hn2Vt4D5YL2iQCPgH6pXulKtpYBAB78vFGa6BATIct2XF+dTvL81/xN?= =?us-ascii?Q?kP2jDVeHv2Ld7TGUa2qeqSKI9X2HGtg7i/ZqH7dmZ29Z3V3lYZUQUFlqgC4n?= =?us-ascii?Q?epfGy02LovvitKZ3cd9xQSjDDc2Vx9Edx48nrNEioZ0XEaW5Iq94gdJBqzNQ?= =?us-ascii?Q?HXFB+wCb0Ca057v/DmqyIw6YCuEsIZ28E+ynSoCV37D8bDReSMKdqfpClCIm?= =?us-ascii?Q?745KjCPkgxDxbzuRkwxDAFdHsdd6/rVRx99qGMsSK7BhG9uGEpHIv1R3I+5m?= =?us-ascii?Q?caGzwbtjE8R6YwBcDkQ0HogM4W/QtGxzhk4zB3hOLtVm5HT7KEKaJfjayZEj?= =?us-ascii?Q?4WdttC9LxYdu5C03EXsXcjx/WFbz49?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB421;5:ZOscpzVLXMgVG/sdPlMavm8g+4fPLCRDh9k2kpfpoEKg5yZhh0P+srRe1Uut9hue2qVCXRHtvJdn9+chZ6HMVTaBFOAR/ogB2+D0J1DTMVIyI7XBitxgXWz2mIE04Ac0iDoQOV9WVnEkjK01E2VnLw==;24:rTpCLaAlxk0Oudco+CSCrY30t3p9gkACDb7TrBJ1y98eH2qvBgB+MJ0z2XBl43oGMKfNX/XEIdDwwUieRZgkagDkPLJZPmTpkaTqTfnr8TI= X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2016 21:40:45.8766 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[12.216.194.146];Helo=[lab-41.internal.tilera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB421 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently on arm there is code that checks whether it should call dump_stack() explicitly, to avoid trying to raise an NMI when the current context is not preemptible by the backtrace IPI. Similarly, the forthcoming arch/tile support uses an IPI mechanism that does not support generating an NMI to self. Accordingly, move the code that guards this case into the generic mechanism, and invoke it unconditionally whenever we want a backtrace of the current cpu. It seems plausible that in all cases, dump_stack() will generate better information than generating a stack from the NMI handler. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf --- arch/arm/kernel/smp.c | 9 --------- lib/nmi_backtrace.c | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 208125658e56..26a9ac6bc616 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -746,15 +746,6 @@ core_initcall(register_cpufreq_notifier); static void raise_nmi(cpumask_t *mask) { - /* - * Generate the backtrace directly if we are running in a calling - * context that is not preemptible by the backtrace IPI. Note - * that nmi_cpu_backtrace() automatically removes the current cpu - * from mask. - */ - if (cpumask_test_cpu(smp_processor_id(), mask) && irqs_disabled()) - nmi_cpu_backtrace(NULL); - smp_cross_call(mask, IPI_CPU_BACKTRACE); } diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c index f878efc9e851..b9a92b90b914 100644 --- a/lib/nmi_backtrace.c +++ b/lib/nmi_backtrace.c @@ -76,6 +76,15 @@ void nmi_trigger_cpumask_backtrace(const cpumask_t *mask, seq_buf_init(&s->seq, s->buffer, NMI_BUF_SIZE); } + /* + * Don't try to send an NMI to this cpu; it may work on some + * architectures, but on others it may not, and we'll get + * information at least as useful just by doing a dump_stack() here. + * Note that nmi_cpu_backtrace(NULL) will clear the cpu bit. + */ + if (cpumask_test_cpu(this_cpu, to_cpumask(backtrace_mask))) + nmi_cpu_backtrace(NULL); + if (!cpumask_empty(to_cpumask(backtrace_mask))) { pr_info("Sending NMI from CPU %d to CPUs %*pbl:\n", this_cpu, nr_cpumask_bits, to_cpumask(backtrace_mask)); -- 2.1.2