From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics
Date: Mon, 29 Feb 2016 14:36:26 -0800 [thread overview]
Message-ID: <1456785386-19481-8-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1456785386-19481-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Add an extra check for frontend stalled in the metrics.
This avoids an extra column for the --metric-only case
when the CPU does not support frontend stalled.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/stat-shadow.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 5e2d2e3..7f87ed7 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -2,6 +2,7 @@
#include "evsel.h"
#include "stat.h"
#include "color.h"
+#include "pmu.h"
enum {
CTX_BIT_USER = 1 << 0,
@@ -35,6 +36,7 @@ static struct stats runtime_dtlb_cache_stats[NUM_CTX][MAX_NR_CPUS];
static struct stats runtime_cycles_in_tx_stats[NUM_CTX][MAX_NR_CPUS];
static struct stats runtime_transaction_stats[NUM_CTX][MAX_NR_CPUS];
static struct stats runtime_elision_stats[NUM_CTX][MAX_NR_CPUS];
+static bool have_frontend_stalled;
struct stats walltime_nsecs_stats;
@@ -75,6 +77,7 @@ void perf_stat__reset_shadow_stats(void)
sizeof(runtime_transaction_stats));
memset(runtime_elision_stats, 0, sizeof(runtime_elision_stats));
memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats));
+ have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
}
/*
@@ -323,7 +326,7 @@ void perf_stat__print_shadow_stats(struct perf_evsel *evsel,
print_metric(ctxp, NULL, "%7.2f ",
"stalled cycles per insn",
ratio);
- } else {
+ } else if (have_frontend_stalled) {
print_metric(ctxp, NULL, NULL,
"stalled cycles per insn", 0);
}
--
2.5.0
next prev parent reply other threads:[~2016-02-29 22:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 22:36 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-29 22:36 ` [PATCH 1/7] perf, tools, stat: Check existence of frontend/backed stalled cycles Andi Kleen
2016-02-29 22:36 ` [PATCH 2/7] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-03-01 12:31 ` Jiri Olsa
2016-03-05 8:17 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-02-29 22:36 ` [PATCH 3/7] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-03-01 12:31 ` Jiri Olsa
2016-03-01 18:52 ` Andi Kleen
2016-03-05 8:17 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-02-29 22:36 ` [PATCH 4/7] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-02-29 22:36 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 14:53 ` Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 18:51 ` Andi Kleen
2016-03-02 11:28 ` Jiri Olsa
2016-03-02 15:38 ` Andi Kleen
2016-03-02 15:46 ` Jiri Olsa
2016-02-29 22:36 ` [PATCH 6/7] perf, tools, stat: Add --metric-only support for -A Andi Kleen
2016-02-29 22:36 ` Andi Kleen [this message]
2016-03-01 12:32 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Jiri Olsa
2016-03-01 13:07 ` perf, tools: Refactor and support interval and CSV metrics Arnaldo Carvalho de Melo
2016-03-01 18:57 Andi Kleen
2016-03-01 18:57 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
2016-03-02 12:04 ` Jiri Olsa
2016-03-03 0:24 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-03 0:24 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
2016-03-03 23:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-03 23:57 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456785386-19481-8-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome