From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Varun Prakash <varun@chelsio.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] target/cxgbit: add INET dependency
Date: Mon, 29 Feb 2016 21:28:28 -0800 [thread overview]
Message-ID: <1456810108.19657.187.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <1456744504-3011977-1-git-send-email-arnd@arndb.de>
Hi Arnd,
On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote:
> The newly added cxgbit driver directly calls functions of the
> IPv4 network stack, which fails if that is disabled:
>
> ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
> ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
>
> This adds a Kconfig dependency to ensure we can't enable this
> driver without the complete network stack it needs.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile")
> ---
> drivers/target/iscsi/cxgbit/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> index cf335b4dbb4e..ce6f5cca315d 100644
> --- a/drivers/target/iscsi/cxgbit/Kconfig
> +++ b/drivers/target/iscsi/cxgbit/Kconfig
> @@ -1,6 +1,7 @@
> config ISCSI_TARGET_CXGB4
> tristate "Chelsio iSCSI target offload driver"
> depends on ISCSI_TARGET && CHELSIO_T4
> + depends on INET
> select CHELSIO_T4_UWIRE
> ---help---
> To compile this driver as module, choose M here: the module
Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
for cxgbit.. ;)
Varun, please pick this up and fold it into the original commit, with
proper credit to Arnd for finding this in the commit log.
next prev parent reply other threads:[~2016-03-01 5:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:14 Arnd Bergmann
2016-03-01 5:28 ` Nicholas A. Bellinger [this message]
2016-03-01 7:28 ` Varun Prakash
2016-03-01 21:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456810108.19657.187.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®