From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbcCAMqx (ORCPT ); Tue, 1 Mar 2016 07:46:53 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34929 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbcCAMqw (ORCPT ); Tue, 1 Mar 2016 07:46:52 -0500 From: Sudip Mukherjee To: Alessandro Zummo , Alexandre Belloni Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, rtc-linux@googlegroups.com, Sudip Mukherjee Subject: [PATCH] rtc: rtc-generic: use correct header file Date: Tue, 1 Mar 2016 18:16:40 +0530 Message-Id: <1456836400-10102-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The allmodconfig build of m32r fails with errors like: In file included from drivers/rtc/rtc-generic.c:12:0: arch/m32r/include/asm/rtc.h:46:8: error: redefinition of 'struct rtc_time' drivers/rtc/rtc-generic.c: In function 'generic_get_time': drivers/rtc/rtc-generic.c:16:21: error: implicit declaration of function 'get_rtc_time' drivers/rtc/rtc-generic.c:18:12: error: 'RTC_BATT_BAD' undeclared drivers/rtc/rtc-generic.c: In function 'generic_set_time': drivers/rtc/rtc-generic.c:26:6: error: implicit declaration of function 'set_rtc_time' Apart from m32r, many other arch like xtensa, sparc are failing with: drivers/rtc/rtc-generic.c:12:21: fatal error: asm/rtc.h: No such file or directory Other rtc drivers are using asm-generic/rtc.h, so use it here. Fixes: 2a32c792f1c9 ("rtc: enable COMPILE_TEST") Signed-off-by: Sudip Mukherjee --- m32r allmodconfig build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780210 failure with sparc and xtensa needs more work as after this patch also they fail with error about missing file "mc146818rtc.h". drivers/rtc/rtc-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-generic.c b/drivers/rtc/rtc-generic.c index e782ebd..494dd85 100644 --- a/drivers/rtc/rtc-generic.c +++ b/drivers/rtc/rtc-generic.c @@ -9,7 +9,7 @@ #include #include -#include +#include static int generic_get_time(struct device *dev, struct rtc_time *tm) { -- 1.9.1