From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbcCBKPO (ORCPT ); Wed, 2 Mar 2016 05:15:14 -0500 Received: from mail-by2on0071.outbound.protection.outlook.com ([207.46.100.71]:60562 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753332AbcCBKPJ (ORCPT ); Wed, 2 Mar 2016 05:15:09 -0500 X-Greylist: delayed 1051 seconds by postgrey-1.27 at vger.kernel.org; Wed, 02 Mar 2016 05:15:09 EST Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=altera.com; From: Ley Foon Tan To: Bjorn Helgaas CC: , , Ley Foon Tan , Ley Foon Tan Subject: [PATCH] PCI: altera: fix altera_pcie_link_is_up() Date: Wed, 2 Mar 2016 17:43:07 +0800 Message-ID: <1456911787-3576-1-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(199003)(189002)(36756003)(229853001)(50226001)(5003940100001)(47776003)(50986999)(105596002)(106466001)(92566002)(81156009)(48376002)(189998001)(5001960100004)(42186005)(11100500001)(107886002)(2906002)(5008740100001)(110136002)(6806005)(33646002)(586003)(50466002)(1096002)(1220700001)(86362001)(19580405001)(87936001)(19580395003)(4001430100002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0301MB2030;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD051;1:5ZX6QijlcLJ+69yjy57Nginy3Noxcueu1tl79J7I3LIGBHc3Stn7YV1WW7/1/JJDzDctuB6fwzGcF2Wq0oW/0bnd/pEL8d1XZG6QHpGwS+mgIjDpqCgYCmCNjkw/15K4ogjlNioH7U78nGW8MJ7Bk1zfCRRAZX7999hmGXEdkgdlF+EXLmBUIRACvVDmGMRaT58mtQd0SfO8tHyghMN4qFkXcjvAFdnbmDM2gkchzSTjIRgGbKww1DwXa9nlHyKAKEH74cKz6P2OVmha+8XdmRLKDWZh3R+0B1xEGWrD8GlZxj38N9/ayFV9FED+OqSRbltmYxFM83L21Z6ughS94chx9PJgAFaW7fQf5+Qu14ZUxWelOxLYxePVFqQDevbSL5BB2MIPd9ASQuSY8pzMRglHfBoQx8t+vDwPpI8CT+tiR0mCTDE/pdjyEMcm1/fEn8AyMsoSqhPt9xaX5UhvAA== X-MS-Office365-Filtering-Correlation-Id: 5969e32f-6e01-4e62-6926-08d3427f1331 X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2030;2:QSB3V0qAz/Vq7+HOHEFg4NT4Xmxj7fOrZB40SOvMxX2O6h2eJGBcbh/GvkOT5X/92/VBzvhJiwuF8Obzf4iLqGfoPFfU6qXHIKv172qUnDFq4BW3WtGQomb4XUtuWkCznH0aAmdBWIF5popoPl83bjneN5qavAH/s6V7qo/nE7GhILMLYDWjZWl5AF0RmHWu;3:cnoJcY5qiUZw/J1n1puyNMwvx3S3Q9HjObyzCQ+CoRuIUOeLq4EscllijVxLQ5DHG0a+GpatADQ7Y/pxjNgLrSYskUos41a1B6ae8ha+iiQI5M8TqHf6uy8XIelQ14BHYw5N7NAb8huI7hmED8Q6RznbdMDJ53px4TWbiXVRHhtGNWMF5a9sy5Y2bS79sJ0n;25:j1PXjNMRWLmQcEiyZJqpkI78GqkHVUDu0dZXEdmeWDmblw6Anetzun8N1y0m2opU+WsiahE67bkKKm9hYuDAixBPAkW1/5WGjojg9UDWKGs36fj0NCFuQSZcd0Y6416a6ZqX8fMRM0K4fyFVU1FZpINSXfCzitNQjDsiUgzG97uT26HsHKpAKadbp/emFPOgkp5w6ZvsFv7yUV84EEUyM1vLDcqimVaYgQ33Sr8EutQDe2TXZ+Id0c6IAVkJtTzPeb26j7yoWUq76uG/bJrzQ8kxb+It3s4Vdi0lFs5HMC4Nnq2xEf0llqrM2X+rT/iZpfbIM1Jw99qC/suTk1Ge7+3/d9Rfc++UL5uetkdJE4aq7Hnnde4vSE0LhAQgkATL0kQyTCI7Y8cP+IxygCLjcQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2030; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2030;20:s6NorfrFPhccY+cR3/gx7Vh1TVJJ3z/g1PGqi5hUM2KjbujckxNymWf1BOfC7dVb648VUB6dXV75V5aEZ28ITaI/zbIgyO6q4CCmhvsmVGm7hBU3t5cXWT9+cTes23b1P72FfW3lbFkAt+TiLlVoQnJM0YCYmspbNRrvZGCS3AE=;4:aQfSOY0iYijahqDl9uPoHt1XYwQ4M4uRvoO2QLfRFatQRdcPa+73otM4Ka5cGGp/n3TlieoN60MVKZuofeVdLxFpfk8ElHQUIJE1KlbKDOi2Xk7yVp8GHYvpRhmmCBW+Ec5fR4xKQyYA2i+z1wNQ1n2wIQnoqoBh/PCHGN6F18rZJxuxy1dggJ4JDOfbjFPJ9LjAA4uUgcpiQt6hmkXR/1EmdN5nQCMhEhoE2DHl95LO5g5So5zIWhBQvK5Df9NKuDB6r9KFX73hNHRI45m72TeRnEZSJEjwiQBEcugyOFAYv9FBAxWRe6Q0XQW8BXW2NR11t955GnjCEoubejuXwITHCas3IJrGKKZ9+1wSGXPyxZniO4mtksWPjbKiT49SOsO5L7BdCdJU8u9dEbB2mwNydRyqDRmgmImCeB0f5OGIHhy9fJGHMwmHselPld2IJjFwMjxSCMYlV2RIQNpmOA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(5005006)(8121501046)(13018025)(3002001)(10201501046);SRVR:SN1PR0301MB2030;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2030; X-Forefront-PRVS: 086943A159 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR0301MB2030;23:au1i2IttoUmQygpjPN9ptdsaZ9C5kCHrdGGA6HP?= =?us-ascii?Q?McUi6zN4ZXx1vwjKAs/Dvti4XVqjqW5a01nUT+lzhzogRvt9LQNoDHbLp3Qh?= =?us-ascii?Q?bsP/3uNHBrZRW8tisl6bUin06RGuzeYaYX6oneCIDYuc9MOshujAygxlOjg0?= =?us-ascii?Q?iOTYkx1ZtFfNFUrE6foa6VtyFzMWTbz9kRjNKgqo2+ikiWgx39KZA7BHIVK4?= =?us-ascii?Q?WaFJbyu5JJYuLsxMHkVPEn+jknmWejcHd5EPVgSbagrY/GtrQElvBf28XKL8?= =?us-ascii?Q?tvmoegVHkAAIGYKXa+r1yL8Jy96SD6QxDuOsN5Cj5u9vE4KQcvsif9FQZnMy?= =?us-ascii?Q?xHhze34FFbi2drP8lbH88TsgmB0kRPFa/OyOTJ81vb9o1eq45qAHhYThSNSI?= =?us-ascii?Q?Z/yINFPk+tYNgk01VTkP+yqbACC0J7N3QGNwvrVQElqM1MU3M8vKSpDKcDfq?= =?us-ascii?Q?QKfGPnRHSKntFjbjsuFxnWjnEvBSYN3PgPSSSAYgTDlvzwWGMKg1OABOVB3i?= =?us-ascii?Q?CmcBOpc46M+rR0tRlWn84SrWOMMC4Md7rcZoXLEvJiVAfpdvTRert4lTsCTc?= =?us-ascii?Q?1jnsIhsBcxfwrUN0l8DOGW5bcRveZlaG/W8unUvbVaFex6jOE66XzCOZhlUh?= =?us-ascii?Q?B+JiedWbJCyKzSQA81smhx4NX3XWP+eFMc6TGnyTViIasVvXE3hNZ89MYq5B?= =?us-ascii?Q?MmGVY/ocSTHflNTOYznn4svph5DaLqZxsd2b5FaaQCYC51bAtZnHTCnprrUI?= =?us-ascii?Q?zJyEMZDC4ZzHoNKFx7sMpO6RClXrKbGM/Ug19LrO5gKVYjC11VSQ0F+W0yxg?= =?us-ascii?Q?V8ZPI+wVdFBCcmlV0jzA1gxfDqZwyV3cteX/lN6G9dPho66GuqgLGiWs1/U0?= =?us-ascii?Q?YnzxHIXcDBAtUEyZ5AjFA7Nm7xQWAJezxTE9pSBBGOyUw1R9+gRHwwTME+bd?= =?us-ascii?Q?bQYc6SzSlNLmnaFRjnxEIk8p9wM77lLQnP5vIIz0n4w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2030;5:hfgB7TD6CJsyAnm9GJp0Eq+C3WFxzltfUHZ8g3mxyV8zVrAVBTIyJ6aSZarqLyIPbZaAvxEFr9xuitQ1M+qSuKK0jepojlJjFQdiJLLvE7a3V6RJ+P/1px9iJfq6NPdbwCqWuB6llj1N7UvDAK6ngw==;24:sv8ZQXDaQZWx5FfJy23kKd4jCrmBZJzNQKPgHp5gkHtsi+Rt2vXwgGuM1UtM8BG0xlAwNcuipcBepagOpk+ElP8vUk8Ta0Sswkw6huKN9PQ=;20:pw9Ha11+wvK8hY+kqa4PTLkd8nQGH2PaG5nYY9FxB6NKCY29E9ncQLJ5TzmhiaBX7uhIbLsRp/yywT8HnthpFBw/va8j612eXJKnZEU9WPE2Q5uNJ07fdx1PhKEF9+vJaGSdIqKlhheq0BS1WhRnOzzw03qeulwI8qQK91U5RsE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 09:43:13.6225 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2030 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The original code return true if RP_LTSSM register return non-zero value. This fix to return true only RP_LTSSM register is in L0 state (link up). Signed-off-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index 99da549..dbac6fb 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -40,6 +40,7 @@ #define P2A_INT_ENABLE 0x3070 #define P2A_INT_ENA_ALL 0xf #define RP_LTSSM 0x3c64 +#define RP_LTSSM_MASK 0x1f #define LTSSM_L0 0xf /* TLP configuration type 0 and 1 */ @@ -140,7 +141,7 @@ static void tlp_write_tx(struct altera_pcie *pcie, static bool altera_pcie_link_is_up(struct altera_pcie *pcie) { - return !!(cra_readl(pcie, RP_LTSSM) & LTSSM_L0); + return !!((cra_readl(pcie, RP_LTSSM) & RP_LTSSM_MASK) == LTSSM_L0); } static bool altera_pcie_valid_config(struct altera_pcie *pcie, -- 2.2.0