From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbcCBKZw (ORCPT ); Wed, 2 Mar 2016 05:25:52 -0500 Received: from down.free-electrons.com ([37.187.137.238]:39504 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754496AbcCBKZt (ORCPT ); Wed, 2 Mar 2016 05:25:49 -0500 From: Alexandre Belloni To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , Juergen Borleis , linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 2/2] rtc: pcf85063: remove struct pcf85063 Date: Wed, 2 Mar 2016 11:25:43 +0100 Message-Id: <1456914343-4611-2-git-send-email-alexandre.belloni@free-electrons.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1456914343-4611-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1456914343-4611-1-git-send-email-alexandre.belloni@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No members of struct pcf85063 are used anymore, remove the whole structure. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85063.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 550f67518c5a..e8ddbb359d11 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -31,11 +31,6 @@ static struct i2c_driver pcf85063_driver; -struct pcf85063 { - struct rtc_device *rtc; - int voltage_low; /* indicates if a low_voltage was detected */ -}; - static int pcf85063_stop_clock(struct i2c_client *client, u8 *ctrl1) { s32 ret; @@ -168,25 +163,18 @@ static const struct rtc_class_ops pcf85063_rtc_ops = { static int pcf85063_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct pcf85063 *pcf85063; + struct rtc_device *rtc; dev_dbg(&client->dev, "%s\n", __func__); if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - pcf85063 = devm_kzalloc(&client->dev, sizeof(struct pcf85063), - GFP_KERNEL); - if (!pcf85063) - return -ENOMEM; - - i2c_set_clientdata(client, pcf85063); - - pcf85063->rtc = devm_rtc_device_register(&client->dev, - pcf85063_driver.driver.name, - &pcf85063_rtc_ops, THIS_MODULE); + rtc = devm_rtc_device_register(&client->dev, + pcf85063_driver.driver.name, + &pcf85063_rtc_ops, THIS_MODULE); - return PTR_ERR_OR_ZERO(pcf85063->rtc); + return PTR_ERR_OR_ZERO(rtc); } static const struct i2c_device_id pcf85063_id[] = { -- 2.7.0