mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>
To: linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Cc: Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] leds: Add driver for the ISSI IS31FL32xx family of LED controllers
Date: Wed,  2 Mar 2016 22:01:31 -0500	[thread overview]
Message-ID: <1456974095-1867-1-git-send-email-drivshin.allworx@gmail.com> (raw)

From: David Rivshin <drivshin@allworx.com>

This series adds support for the ISSI IS31FL32xx family of I2C LED
controllers. Since the IS31FL3218 is actually the same device as the
SN3218, the dedicated leds-sn3218 driver is removed and the compatible
string is folded into this driver.

Changes from RFC [1]:
 - Removed max-brightness DT property.
 - Added #address-cells and #size-cells properties to the example DT.
 - Refer to these devices as "LED controllers" in Kconfig.
 - Removed redundant last sentence from Kconfig entry
 - Removed unnecessary debug code.
 - Do not set led_classdev.brightness to 0 explicitly, as it is
   already initialized to 0 by devm_kzalloc().
 - Used of_property_read_string() instead of of_get_property().
 - Fail immediately on DT parsing error in a child node, rather than
   continuing on with the non-faulty ones.
 - Added additional comments for some things that might be non-obvious.
 - Added constants for the location of the SSD bit in the SHUTDOWN
   register, and the 3216's CONFIG register.
 - Added special sw_shutdown_func for the 3216 device, as that bit
   is in a different register, at a different position, and has reverse
   polarity compared to all the other devices.
 - Refactored is31fl32xx_init_regs() to separate out some logic into
   is31fl32xx_reset_regs() and is31fl32xx_software_shutdown().
 - Added 4th patch to replace the now-redundant leds-sn3218.

[1] http://www.spinics.net/lists/linux-leds/msg05564.html
    http://thread.gmane.org/gmane.linux.leds/4530

David Rivshin (4):
  DT: Add vendor prefix for Integrated Silicon Solutions Inc.
  DT: leds: Add binding for the ISSI IS31FL32xx family of LED
    controllers
  leds: Add driver for the ISSI IS31FL32xx family of LED controllers
  leds: Replace dedicated SN3218 driver with IS31FL32XX driver

 .../devicetree/bindings/leds/leds-is31fl32xx.txt   |  52 +++
 .../devicetree/bindings/leds/leds-sn3218.txt       |  41 --
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 drivers/leds/Kconfig                               |  16 +-
 drivers/leds/Makefile                              |   2 +-
 drivers/leds/leds-is31fl32xx.c                     | 509 +++++++++++++++++++++
 drivers/leds/leds-sn3218.c                         | 306 -------------
 7 files changed, 569 insertions(+), 358 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
 create mode 100644 drivers/leds/leds-is31fl32xx.c
 delete mode 100644 drivers/leds/leds-sn3218.c

-- 
2.5.0

             reply	other threads:[~2016-03-03  3:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  3:01 David Rivshin (Allworx) [this message]
2016-03-03  3:01 ` [PATCH 1/4] DT: Add vendor prefix for Integrated Silicon Solutions Inc David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring
2016-03-03  3:01 ` [PATCH 2/4] DT: leds: Add binding for the ISSI IS31FL32xx family of LED controllers David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring
2016-03-03  3:01 ` [PATCH 3/4] leds: Add driver " David Rivshin (Allworx)
2016-03-03  3:21   ` kbuild test robot
2016-03-03 14:51   ` Jacek Anaszewski
2016-03-04  0:45     ` David Rivshin (Allworx)
2016-03-04  7:54       ` Jacek Anaszewski
2016-03-04 15:05         ` David Rivshin (Allworx)
2016-03-04 16:01           ` Jacek Anaszewski
2016-03-04 19:02             ` David Rivshin (Allworx)
2016-03-04 21:39               ` Jacek Anaszewski
2016-03-05  5:29                 ` David Rivshin (Allworx)
2016-03-05 11:37                   ` Jacek Anaszewski
2016-03-03 18:13   ` Stefan Wahren
2016-03-04 14:27     ` David Rivshin (Allworx)
2016-03-04 15:38       ` Jacek Anaszewski
2016-03-05  6:12         ` David Rivshin (Allworx)
2016-03-05 11:39           ` Jacek Anaszewski
2016-03-03  3:01 ` [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver David Rivshin (Allworx)
2016-03-03 14:51   ` Jacek Anaszewski
2016-03-05  5:34     ` David Rivshin (Allworx)
2016-03-05 11:37       ` Jacek Anaszewski
2016-03-04 21:14   ` Stefan Wahren
2016-03-05  5:00     ` David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456974095-1867-1-git-send-email-drivshin.allworx@gmail.com \
    --to=drivshin.allworx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®