From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [patch -target tree] usb: gadget: f_tcm: use after free
Date: Fri, 04 Mar 2016 23:26:58 -0800 [thread overview]
Message-ID: <1457162818.19657.282.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <87k2ll856m.fsf@ti.com>
Hi Felipe + usb-gadget folks,
On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> > We need to move the kfree() down a line so we don't dereference a freed
> > variable.
> >
> > Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to target_alloc_session')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> It's okay to take this via target:
>
> Signed-off-by: Felipe Balbi <balbi@kernel.org>
>
Note this specific patch is only a mechanical change, and we still need
reviews for the more interesting conversions:
usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation
http://www.spinics.net/lists/target-devel/msg11777.html
usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs
http://www.spinics.net/lists/target-devel/msg11782.html
Felipe, Sebastian, & Andrezj, would you be so kind to review and test
usb-gadget using target-pending/for-next code..?
next prev parent reply other threads:[~2016-03-05 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 10:08 Dan Carpenter
2016-03-02 11:55 ` Felipe Balbi
2016-03-05 7:26 ` Nicholas A. Bellinger [this message]
2016-03-09 11:38 ` Felipe Balbi
2016-03-10 6:23 ` Nicholas A. Bellinger
2016-03-09 12:53 ` Andrzej Pietrasiewicz
2016-03-10 5:19 ` Nicholas A. Bellinger
2016-03-10 8:34 ` Andrzej Pietrasiewicz
2016-03-11 4:10 ` Nicholas A. Bellinger
2016-03-05 7:20 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457162818.19657.282.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=andrzej.p@samsung.com \
--cc=balbi@kernel.org \
--cc=bart.vanassche@sandisk.com \
--cc=bigeasy@linutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®