From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Chris Boot <bootc@bootc.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
target-devel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sbp-target: checking for NULL instead of IS_ERR
Date: Sat, 05 Mar 2016 01:33:14 -0800 [thread overview]
Message-ID: <1457170394.19657.291.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <2A1ED37C-C556-4B3D-A59B-3369E5DFB4D5@bootc.net>
On Sat, 2016-03-05 at 08:45 +0000, Chris Boot wrote:
> On 5 Mar 2016, at 07:33, Nicholas A. Bellinger <nab@linux-iscsi.org> wrote:
> >
> > Hi Dan + BootC,
> >
> > On Wed, 2016-03-02 at 13:09 +0300, Dan Carpenter wrote:
> >> We changed this from kzalloc to sbp_mgt_get_req() so we need to change
> >> from checking for NULL to check for error pointers.
> >>
> >> Fixes: c064b2a78989 ('sbp-target: Conversion to percpu_ida tag pre-allocation')
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >>
> >> diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
> >> index 251d532..a04b0605f 100644
> >> --- a/drivers/target/sbp/sbp_target.c
> >> +++ b/drivers/target/sbp/sbp_target.c
> >> @@ -951,7 +951,7 @@ static void tgt_agent_fetch_work(struct work_struct *work)
> >>
> >> while (next_orb && tgt_agent_check_active(agent)) {
> >> req = sbp_mgt_get_req(sess, sess->card, next_orb);
> >> - if (!req) {
> >> + if (IS_ERR(req)) {
> >> spin_lock_bh(&agent->lock);
> >> agent->state = AGENT_STATE_DEAD;
> >> spin_unlock_bh(&agent->lock);
> >
> > Fixed + folded into the original patch.
> >
> > Thanks Dan.
> >
> > Chris, would you be so kind to review the original changes here:
> >
> > sbp-target: Conversion to percpu_ida tag pre-allocation
> > http://www.spinics.net/lists/target-devel/msg11778.html
> >
> > sbp-target: Convert to TARGET_SCF_ACK_KREF I/O krefs
> > http://www.spinics.net/lists/target-devel/msg11780.html
> >
> > and verify on your local IEEE1394 target setup..?
>
> Hi Nic, Dan,
>
> I’m away this weekend so I can’t test these for a few days at least,
> unfortunately. I must admit I only vaguely follow the changes here as
> I haven’t been keeping up with the pace of change in target-devel
> lately, but it generally looks OK I think.
>
> Are these in linux-next or another branch somewhere I can easily clone
> them from?
The patch series is in target-pending/for-next.
>
> How soon do you need my ACK/NAK on these?
>
Assuming the merge window opens on the 13th, any time over the next 7-10
days would be fine.
next prev parent reply other threads:[~2016-03-05 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 10:09 Dan Carpenter
2016-03-05 7:33 ` Nicholas A. Bellinger
2016-03-05 8:45 ` Chris Boot
2016-03-05 9:33 ` Nicholas A. Bellinger [this message]
2016-03-10 20:56 ` Chris Boot
2016-03-10 21:52 ` Chris Boot
2016-03-10 22:58 ` Chris Boot
2016-03-11 4:33 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457170394.19657.291.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=bootc@bootc.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®