From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbcCGNPJ (ORCPT ); Mon, 7 Mar 2016 08:15:09 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38291 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbcCGNPE (ORCPT ); Mon, 7 Mar 2016 08:15:04 -0500 From: Dmitry Vasilyanov To: Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Vasilyanov Subject: [PATCH] ARM: mm: fix address check in change_memory_common() Date: Mon, 7 Mar 2016 16:17:18 +0300 Message-Id: <1457356638-16410-1-git-send-email-vdmit11@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The (start >= MODULES_END) is checked twice. The second check has no sense. Clearly, the intention was: (end >= MODULE_CHECK). Seems to be a typo, so this patch fixes it. --- arch/arm/mm/pageattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c index d19b1ad..9edf6b0 100644 --- a/arch/arm/mm/pageattr.c +++ b/arch/arm/mm/pageattr.c @@ -55,7 +55,7 @@ static int change_memory_common(unsigned long addr, int numpages, if (start < MODULES_VADDR || start >= MODULES_END) return -EINVAL; - if (end < MODULES_VADDR || start >= MODULES_END) + if (end < MODULES_VADDR || end >= MODULES_END) return -EINVAL; data.set_mask = set_mask; -- 2.1.4