From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [PATCH 3/9] KVM: MMU: use kvm_sync_page in kvm_sync_pages
Date: Mon, 7 Mar 2016 15:15:49 +0100 [thread overview]
Message-ID: <1457360155-9610-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1457360155-9610-1-git-send-email-pbonzini@redhat.com>
If the last argument is true, kvm_unlink_unsync_page is called anyway in
__kvm_sync_page (either by kvm_mmu_prepare_zap_page or by __kvm_sync_page
itself). Therefore, kvm_sync_pages can just call kvm_sync_page, instead
of going through kvm_unlink_unsync_page+__kvm_sync_page.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/mmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 45a8a0605a09..56be33714036 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1987,8 +1987,7 @@ static void kvm_sync_pages(struct kvm_vcpu *vcpu, gfn_t gfn)
continue;
WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL);
- kvm_unlink_unsync_page(vcpu->kvm, s);
- if (!__kvm_sync_page(vcpu, s, &invalid_list, false))
+ if (!kvm_sync_page(vcpu, s, &invalid_list))
flush = true;
}
--
1.8.3.1
next prev parent reply other threads:[~2016-03-07 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 14:15 [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations Paolo Bonzini
2016-03-07 14:15 ` Paolo Bonzini
2016-03-08 8:00 ` Takuya Yoshikawa
2016-03-08 8:30 ` Paolo Bonzini
2016-03-08 8:33 ` Takuya Yoshikawa
2016-03-07 14:15 ` [PATCH 1/9] KVM: MMU: introduce kvm_mmu_flush_or_zap Paolo Bonzini
2016-03-07 14:15 ` [PATCH 2/9] KVM: MMU: move TLB flush out of __kvm_sync_page Paolo Bonzini
2016-03-07 14:15 ` Paolo Bonzini [this message]
2016-03-07 14:15 ` [PATCH 4/9] KVM: MMU: cleanup __kvm_sync_page and its callers Paolo Bonzini
2016-03-07 14:15 ` [PATCH 5/9] KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page* Paolo Bonzini
2016-03-07 14:15 ` [PATCH 6/9] KVM: MMU: move zap/flush to kvm_mmu_get_page Paolo Bonzini
2016-03-07 14:15 ` [PATCH 7/9] KVM: MMU: coalesce more page zapping in mmu_sync_children Paolo Bonzini
2016-03-07 14:15 ` [PATCH 8/9] KVM: MMU: simplify is_last_gpte Paolo Bonzini
2016-03-07 14:15 ` [PATCH 9/9] KVM: MMU: micro-optimize gpte_access Paolo Bonzini
2016-03-09 7:12 ` [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457360155-9610-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®