mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
To: hubert.chrzaniuk@intel.com, lukasz.anaczkowski@intel.com,
	mchehab@osg.samsung.com, dougthompson@xmission.com, bp@alien8.de,
	linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver
Date: Mon,  7 Mar 2016 15:30:45 +0100	[thread overview]
Message-ID: <1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com> (raw)

Patch corrects a typo introduced previously.
As a result under some configurations dimms were not
correctly recognized. Problem affects only Xeon Phi architecture.

Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
---
 drivers/edac/sb_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index e438ee5..f5c6b97 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -1574,7 +1574,7 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
 				for (cha = 0; cha < KNL_MAX_CHAS; cha++) {
 					if (knl_get_mc_route(target,
 						mc_route_reg[cha]) == channel
-						&& participants[channel]) {
+						&& !participants[channel]) {
 						participant_count++;
 						participants[channel] = 1;
 						break;
-- 
1.8.3.1

             reply	other threads:[~2016-03-07 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 14:30 Hubert Chrzaniuk [this message]
2016-03-07 15:24 ` Borislav Petkov
2016-03-08  9:18   ` Chrzaniuk, Hubert
2016-03-08 10:28     ` Borislav Petkov
2016-03-07 16:20 ` Aristeu Rozanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com \
    --to=hubert.chrzaniuk@intel.com \
    --cc=bp@alien8.de \
    --cc=dougthompson@xmission.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.anaczkowski@intel.com \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®