From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbcCHUl3 (ORCPT ); Tue, 8 Mar 2016 15:41:29 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34575 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbcCHUlL (ORCPT ); Tue, 8 Mar 2016 15:41:11 -0500 From: Rasmus Villemoes To: Kees Cook , Andrew Morton , Duncan Sands , Greg Kroah-Hartman Cc: Rasmus Villemoes , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC 7/7] USB: usbatm: avoid fragile and inefficient snprintf use Date: Tue, 8 Mar 2016 21:40:54 +0100 Message-Id: <1457469654-17059-8-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1457469654-17059-1-git-send-email-linux@rasmusvillemoes.dk> References: <1457469654-17059-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Passing overlapping source and destination is fragile, and in this case we can even simplify the code and avoid the huge stack buffer by using the %p extension for printing a small hex dump. Signed-off-by: Rasmus Villemoes --- drivers/usb/atm/usbatm.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index db322d9ccb6e..fb47f9883056 100644 --- a/drivers/usb/atm/usbatm.c +++ b/drivers/usb/atm/usbatm.c @@ -1331,15 +1331,12 @@ MODULE_VERSION(DRIVER_VERSION); static int usbatm_print_packet(struct usbatm_data *instance, const unsigned char *data, int len) { - unsigned char buffer[256]; - int i = 0, j = 0; + int i, j; for (i = 0; i < len;) { - buffer[0] = '\0'; - sprintf(buffer, "%.3d :", i); - for (j = 0; (j < 16) && (i < len); j++, i++) - sprintf(buffer, "%s %2.2x", buffer, data[i]); - dev_dbg(&instance->usb_intf->dev, "%s", buffer); + j = min(16, len-i); + dev_dbg(&instance->usb_intf->dev, "%.3d : %*ph", i, j, data + i); + i += j; } return i; } -- 2.1.4