From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932759AbcCINvg (ORCPT ); Wed, 9 Mar 2016 08:51:36 -0500 Received: from mga01.intel.com ([192.55.52.88]:42083 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbcCINv0 (ORCPT ); Wed, 9 Mar 2016 08:51:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="62828540" From: Mihai Mihalache To: linux-kernel@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com Cc: mihai.d.mihalache@intel.com, hans.holmberg@intel.com, yousaf.kaukab@intel.com Subject: [PATCH] regulator: gpio: check return value of of_get_named_gpio Date: Wed, 9 Mar 2016 05:50:42 -0800 Message-Id: <1457531442-4695-1-git-send-email-mihai.d.mihalache@intel.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At boot time the regulator driver can be initialized before the gpio, in which case the call to of_get_named_gpio will return EPROBE_DEFER. This value is silently passed to regulator_register which will return success, although the gpio is not registered (regulator_ena_gpio_request not called) as the value passed is detected as invalid. The gpio_regulator_probe will therefore succeed with no gpio requested. Signed-off-by: Mihai Mihalache Reviewed-by: Hans Holmberg --- drivers/regulator/gpio-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 464018d..429294f 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers/regulator/gpio-regulator.c @@ -162,6 +162,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np, of_property_read_u32(np, "startup-delay-us", &config->startup_delay); config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0); + if(IS_ERR_VALUE(config->enable_gpio)) + return ERR_PTR(config->enable_gpio); /* Fetch GPIOs. - optional property*/ ret = of_gpio_count(np); -- 1.7.9.5