From: Will Deacon <will.deacon@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] Kconfig: disable LATENCYTOP for IA64
Date: Wed, 9 Mar 2016 16:35:44 +0000 [thread overview]
Message-ID: <1457541344-16961-1-git-send-email-will.deacon@arm.com> (raw)
Commit da48d094ce5d ("Kconfig: remove HAVE_LATENCYTOP_SUPPORT")
allows CONFIG_LATENCYTOP to be selected on all architectures, since
save_stack_trace_tsk is now provided unconditionally by core code.
Unfortunately, this results in a build error for ia64 when the option
is enabled:
arch/ia64/kernel/entry.S: Assembler messages:
arch/ia64/kernel/entry.S:621: Error: Operand 2 of `adds' should be a 14-bit integer (-8192-8191)
arch/ia64/kernel/entry.S:728: Error: Operand 2 of `adds' should be a 14-bit integer (-8192-8191)
arch/ia64/kernel/entry.S:859: Error: Operand 2 of `adds' should be a 14-bit integer (-8192-8191)
make[1]: *** [arch/ia64/kernel/entry.o] Error 1
This is because task_struct is now over 8k thanks to the latency_record
array, which means that the 14-bit immediate offset expect by the adds
instruction to grab hold of the thread info flags is now out-of-range on
ia64. Fixing the ia64 entry code without making it less efficient is
beyond me, but rather than revert da48d094ce5d entirely, we can simply
make LATENCYTOP depend on !IA64 until somebody brave steps up to tackle
the entry code over there.
Cc: Tony Luck <tony.luck@intel.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
I previously reported this on linux-arch, but the conversation didn't
go anywhere: http://marc.info/?l=linux-arch&m=145390684108109
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8bfd1aca7a3d..c8d12808b9aa 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1615,6 +1615,7 @@ config LATENCYTOP
depends on DEBUG_KERNEL
depends on STACKTRACE_SUPPORT
depends on PROC_FS
+ depends on !IA64
select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM_UNWIND && !ARC
select KALLSYMS
select KALLSYMS_ALL
--
2.1.4
reply other threads:[~2016-03-09 16:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457541344-16961-1-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®