mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Elaine Zhang <zhangqing@rock-chips.com>
To: heiko@sntech.de, khilman@baylibre.com, xf@rock-chips.com,
	wxt@rock-chips.com
Cc: linux-arm-kernel@lists.infradead.org, huangtao@rock-chips.com,
	zyw@rock-chips.com, xxx@rock-chips.com, jay.xu@rock-chips.com,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Elaine Zhang <zhangqing@rock-chips.com>
Subject: [PATCH v6 1/6] rockchip: power-domain: make idle handling optional
Date: Thu, 10 Mar 2016 05:00:36 +0800	[thread overview]
Message-ID: <1457557241-21297-2-git-send-email-zhangqing@rock-chips.com> (raw)
In-Reply-To: <1457557241-21297-1-git-send-email-zhangqing@rock-chips.com>

Not all new socs need to handle idle states on domain state changes,
so add the possibility to make them optional.

Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
---
 drivers/soc/rockchip/pm_domains.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
index 18aee6b..c46312d 100644
--- a/drivers/soc/rockchip/pm_domains.c
+++ b/drivers/soc/rockchip/pm_domains.c
@@ -68,9 +68,9 @@ struct rockchip_pmu {
 {						\
 	.pwr_mask = BIT(pwr),			\
 	.status_mask = BIT(status),		\
-	.req_mask = BIT(req),			\
-	.idle_mask = BIT(idle),			\
-	.ack_mask = BIT(ack),			\
+	.req_mask = (req >= 0) ? BIT(req) : 0,		\
+	.idle_mask = (idle >= 0) ? BIT(idle) : 0,	\
+	.ack_mask = (ack >= 0) ? BIT(ack) : 0,		\
 }
 
 #define DOMAIN_RK3288(pwr, status, req)		\
@@ -96,6 +96,9 @@ static int rockchip_pmu_set_idle_request(struct rockchip_pm_domain *pd,
 	struct rockchip_pmu *pmu = pd->pmu;
 	unsigned int val;
 
+	if (pd_info->req_mask == 0)
+		return 0;
+
 	regmap_update_bits(pmu->regmap, pmu->info->req_offset,
 			   pd_info->req_mask, idle ? -1U : 0);
 
-- 
1.9.1

  reply	other threads:[~2016-03-10  2:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 21:00 [PATCH v6 0/6] rockchip: power-domain: fix pm domain for support RK3399 SoC Elaine Zhang
2016-03-09 21:00 ` Elaine Zhang [this message]
2016-03-09 21:00 ` [PATCH v6 2/6] power-domain: allow domains only handling idle requests Elaine Zhang
2016-03-09 21:00 ` [PATCH v6 3/6] rockchip: power-domain: add support for sub-power domains Elaine Zhang
2016-03-09 21:00 ` [PATCH v6 4/6] dt/bindings: power: add RK3399 SoCs header for power-domain Elaine Zhang
2016-03-09 21:02 ` [PATCH v6 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Elaine Zhang
2016-03-09 21:03 ` [PATCH v6 6/6] rockchip: power-domain: Modify power domain driver for rk3399 Elaine Zhang
2016-03-09 21:22 [RESEND PATCH v6 0/6] rockchip: power-domain: fix pm domain for support RK3399 SoC Elaine Zhang
2016-03-09 21:22 ` [PATCH v6 1/6] rockchip: power-domain: make idle handling optional Elaine Zhang
2016-03-28 10:09   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457557241-21297-2-git-send-email-zhangqing@rock-chips.com \
    --to=zhangqing@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=wxt@rock-chips.com \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®