From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932740AbcCJMVa (ORCPT ); Thu, 10 Mar 2016 07:21:30 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:32953 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbcCJMV0 (ORCPT ); Thu, 10 Mar 2016 07:21:26 -0500 From: Sudip Mukherjee To: Jon Mason , Dave Jiang , Allen Hubbe Cc: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Sudip Mukherjee Subject: [PATCH] ntb: fix possible NULL dereference Date: Thu, 10 Mar 2016 17:51:11 +0530 Message-Id: <1457612471-26128-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kmalloc can fail and we should check for NULL before using the pointer returned by kmalloc. Signed-off-by: Sudip Mukherjee --- drivers/ntb/test/ntb_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index c8a37ba..b21e647 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -541,6 +541,8 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf, return 0; buf = kmalloc(64, GFP_KERNEL); + if (!buf) + return -ENOMEM; out_offset = snprintf(buf, 64, "%d\n", perf->run); ret = simple_read_from_buffer(ubuf, count, offp, buf, out_offset); kfree(buf); -- 1.9.1