From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756068AbbJALhw (ORCPT ); Thu, 1 Oct 2015 07:37:52 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:62908 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbbJALhs (ORCPT ); Thu, 1 Oct 2015 07:37:48 -0400 From: Arnd Bergmann To: Alim Akhtar Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JBottomley@odin.com, vinholikatti@gmail.com, amit.daniel@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Date: Thu, 01 Oct 2015 13:37:39 +0200 Message-ID: <1457698.WJ3mz2FHZZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1443686970-28104-12-git-send-email-alim.akhtar@samsung.com> References: <1443686970-28104-1-git-send-email-alim.akhtar@samsung.com> <1443686970-28104-12-git-send-email-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vcVPK/zAnpr6PNGYkuw7yYoeDF6gbl9pObr/ZwWX1eTJ+LzhPv2 jDLiP/kvzsTqC7sUAY9tt1JN4DO/FYaUH1EMyE9DTz9BwcI0FRQBQ7UwZbrsSSlyRvXtY4U Q0c9/SL8Jn3ZXp98r1ElumNYeAJRtZYEeIpQ1l4BwMcOuPI67dKcfnsOhTr3mS9/ihQWZ+m m68qZVDKVj4GpCKcsD/jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wRtfqgQD4+k=:DiDRcUggrX+Zx+oUfDeyD+ Eus8VufWrDouGsqKkoKE+6eLYp3vMVObNSh3D4KowZ7xDX2gg6Gm0A2GjC8Fusl/FzW5PGIGa pk5OegLyIhWu8QlZtuoVXK413dQ53Q+g49szrBrY1c+NTqomOJ9ghGco9GluOdAru8W1fVKAp xgF41ZubB4eUoUFs6ncUe57136niZW77r2msArSrbZsZ1b9gsrxW2gU9o26ByOyvKcuKritgq XOEjJhPRTWfrK3yB055R8Q9h2Gf5/twHwGjDsQ3y+nP8gM0HbJJ1FwwOqCMjSjzeK/E2r4qeB G11xImbgL9A7FYc39QtTwiNQ5PWWr0ZhoTNdO2p+vYN3R0W56tEIBo1bI2sppRZUhd1TdV2Vg lNV6daYHKeeXPacX0EPtkmJ6Cy0Cdc7v0THcCaTzc5Un8zwHaICPBSUkIXW3k4pCvGJoa/MqR Q5gGMR0/5r5b64e/8yfAvE6S46UmOdDnZrbu77tQaf1oLT6hGaux0TnIvjW7K7ocy0DDTST3D iU82dt9J4zI9M/zUYzbDeTiTUyAaQnK5otuHFpIAuUnIBDzm0qI/fkCMhXYXn4hmvEZT4q0Vv 9IZbl7rsSqw6WQ2kbqeuEcKg7wQOCr13mY/aZM/HJMl8R3kJxmX4jANGEpSLtM5uhva1IDWRk JZkqNuRcaOcWzJW5ETposhDwuejYIr/0STyOhbhhFecVC924i7q8dEKPdsw8MjQNT2WmAKcWK 7vI5use9s43kzvek Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 01 October 2015 13:39:28 Alim Akhtar wrote: > From: Seungwon Jeon > > This adds Exynos Universal Flash Storage (UFS) Host Controller DT bindings. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > --- > .../devicetree/bindings/ufs/ufs-exynos.txt | 93 ++++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt > > diff --git a/Documentation/devicetree/bindings/ufs/ufs-exynos.txt b/Documentation/devicetree/bindings/ufs/ufs-exynos.txt > new file mode 100644 > index 0000000..00df72e > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/ufs-exynos.txt > @@ -0,0 +1,93 @@ > +* Exynos Universal Flash Storage (UFS) Host Controller > + > +UFSHC nodes are defined to describe on-chip UFS host controllers. > +Each UFS controller instance should have its own node. > + > +Required properties: > +- compatible : compatible name, contains "samsung,exynos7-ufs" > +- interrupts : > +- reg : This needs a list of all the register ranges, which order they are in and what the respective strings must be. > +- clocks : List of phandle and clock specifier pairs > +- clock-names : List of clock input name strings sorted in the same > + order as the clocks property. You need to list the names you require here. Also the 'clock specifier' includes the phandle, it's not a pair but just a list of specifiers. > +- ufs,pwr-attr-mode : specifies mode value for power mode change > +- ufs,pwr-attr-lane : specifies lane count value for power mode change > +- ufs,pwr-attr-gear : specifies gear count value for power mode change > +- ufs,pwr-attr-hs-series : specifies HS rate series for power mode change > +- ufs,pwr-local-l2-timer : specifies array of local UNIPRO L2 timer values > + > +- ufs,pwr-remote-l2-timer : specifies array of remote UNIPRO L2 timer values > + > +- ufs-rx-adv-fine-gran-sup_en : specifies support of fine granularity of MPHY, > + this is a boolean property. > +- ufs-rx-adv-fine-gran-step : specifies granularity steps of MPHY > +- ufs-rx-adv-min-activate-time-cap : specifies rx advanced minimum activate time of MPHY > +- ufs-pa-granularity : specifies Granularity for PA_TActivate and PA_Hibern8Time > +- ufs-pa-tacctivate : specifies time wake-up remote M-RX > +- ufs-pa-hibern8time : specifies minimum time to wait in HIBERN8 state These all require a specification of what the allowed values are and/or the units for the numbers. > + > + clocks = <&core 0>, <&ref 0>, <&iface 0>; > + clock-names = "core_clk", "ref_clk", "iface_clk"; Better rename them to "core", "ref" and "iface", no point requiring to spell out "clk" here. > + ufs,pwr-attr-mode = "FAST"; A string is rather unusual here, what are the allowed values? Could you use a boolean property instead? > + ufs,pwr-attr-lane = /bits/ 8 <2>; > + ufs,pwr-attr-gear = /bits/ 8 <2>; Why the "/bits/ 8" ? Arnd