mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>,
	Isaac Huang <he.huang@intel.com>
Subject: [PATCH 01/10] staging: lustre: fix bogus lst errors for lnet selftest
Date: Fri, 11 Mar 2016 20:29:42 -0500	[thread overview]
Message-ID: <1457746191-27981-2-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1457746191-27981-1-git-send-email-jsimmons@infradead.org>

From: Isaac Huang <he.huang@intel.com>

It should not be counted as errors if a test RPC
has been stopped due to administrative actions,
e.g. lst end_session from the remote test console.

Signed-off-by: Isaac Huang <he.huang@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4181
Reviewed-on: http://review.whamcloud.com/13279
Reviewed-by: Amir Shehata <amir.shehata@intel.com>
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
---
 drivers/staging/lustre/lnet/selftest/rpc.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c b/drivers/staging/lustre/lnet/selftest/rpc.c
index 5eb4232..60d38df 100644
--- a/drivers/staging/lustre/lnet/selftest/rpc.c
+++ b/drivers/staging/lustre/lnet/selftest/rpc.c
@@ -1427,9 +1427,16 @@ srpc_lnet_ev_handler(lnet_event_t *ev)
 	LASSERT(!in_interrupt());
 
 	if (ev->status) {
+		__u32 errors;
+
 		spin_lock(&srpc_data.rpc_glock);
-		srpc_data.rpc_counters.errors++;
+		if (ev->status != -ECANCELED) /* cancellation is not error */
+			srpc_data.rpc_counters.errors++;
+		errors = srpc_data.rpc_counters.errors;
 		spin_unlock(&srpc_data.rpc_glock);
+
+		CNETERR("LNet event status %d type %d, RPC errors %u\n",
+			ev->status, ev->type, errors);
 	}
 
 	rpcev->ev_lnet = ev->type;
-- 
1.7.1

  reply	other threads:[~2016-03-12  1:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12  1:29 [PATCH 00/10] Cleanup and audit of lnet selftest code James Simmons
2016-03-12  1:29 ` James Simmons [this message]
2016-03-12  1:29 ` [PATCH 02/10] staging: lustre: remove returns in void function for lnet selftest James Simmons
2016-03-12  1:29 ` [PATCH 03/10] staging: lustre: fix spacing issues checkpatch reported in " James Simmons
2016-03-12  1:29 ` [PATCH 04/10] staging: lustre: remove extra spacing of variable declartions for " James Simmons
2016-03-12  1:29 ` [PATCH 05/10] staging: lustre: remove extra spacing when setting variable " James Simmons
2016-03-12  1:29 ` [PATCH 06/10] staging: lustre: filter remaining extra spacing " James Simmons
2016-03-12  1:29 ` [PATCH 07/10] staging: lustre: cleanup comment style " James Simmons
2016-03-12  1:39   ` [lustre-devel] " Dilger, Andreas
2016-03-12  6:24     ` Greg Kroah-Hartman
2016-03-12  6:25       ` Greg Kroah-Hartman
2016-03-12  6:26         ` Greg Kroah-Hartman
2016-03-12  1:29 ` [PATCH 08/10] staging: lustre: test for proper errno code in lstcon_rpc_trans_abort James Simmons
2016-03-12  1:29 ` [PATCH 09/10] staging: lustre: report minimum of two buffers for LNet selftest load test James Simmons
2016-03-12  1:29 ` [PATCH 10/10] staging: lustre: fix aligments in lnet selftest James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457746191-27981-2-git-send-email-jsimmons@infradead.org \
    --to=jsimmons@infradead.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=he.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®