From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219AbcCMT17 (ORCPT ); Sun, 13 Mar 2016 15:27:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55276 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbcCMT1o (ORCPT ); Sun, 13 Mar 2016 15:27:44 -0400 From: Denys Vlasenko To: Konrad Rzeszutek Wilk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Cc: Denys Vlasenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] block/xen-blkback: Deinline put_free_pages, save 645 bytes Date: Sun, 13 Mar 2016 20:27:22 +0100 Message-Id: <1457897243-16043-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 13 Mar 2016 19:27:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function compiles to 170 bytes of machine code. 7 callsites. This function has a spinlocked code section, which is significantly more expensive than call/return overhead. Signed-off-by: Denys Vlasenko CC: Konrad Rzeszutek Wilk CC: Roger Pau Monné CC: xen-devel@lists.xenproject.org CC: linux-kernel@vger.kernel.org --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 4809c15..86798b4 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -142,7 +142,7 @@ static inline int get_free_page(struct xen_blkif_ring *ring, struct page **page) return 0; } -static inline void put_free_pages(struct xen_blkif_ring *ring, struct page **page, +static void put_free_pages(struct xen_blkif_ring *ring, struct page **page, int num) { unsigned long flags; -- 2.5.0