From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300AbcCMT2H (ORCPT ); Sun, 13 Mar 2016 15:28:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55059 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198AbcCMT1y (ORCPT ); Sun, 13 Mar 2016 15:27:54 -0400 From: Denys Vlasenko To: Konrad Rzeszutek Wilk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Cc: Denys Vlasenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] block/xen-blkback: Deinline shrink_free_pagepool, save 204 bytes Date: Sun, 13 Mar 2016 20:27:23 +0100 Message-Id: <1457897243-16043-2-git-send-email-dvlasenk@redhat.com> In-Reply-To: <1457897243-16043-1-git-send-email-dvlasenk@redhat.com> References: <1457897243-16043-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 13 Mar 2016 19:27:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function compiles to 201 bytes of machine code. 2 callsites. This function has a spinlocked code section, which is significantly more expensive than call/return overhead. Signed-off-by: Denys Vlasenko CC: Konrad Rzeszutek Wilk CC: Roger Pau Monné CC: xen-devel@lists.xenproject.org CC: linux-kernel@vger.kernel.org --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 4809c15..5e3394c 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -155,7 +155,7 @@ static inline void put_free_pages(struct xen_blkif_ring *ring, struct page **pag spin_unlock_irqrestore(&ring->free_pages_lock, flags); } -static inline void shrink_free_pagepool(struct xen_blkif_ring *ring, int num) +static void shrink_free_pagepool(struct xen_blkif_ring *ring, int num) { /* Remove requested pages in batches of NUM_BATCH_FREE_PAGES */ struct page *page[NUM_BATCH_FREE_PAGES]; -- 2.5.0