From: Peter Pan <peterpansjtu@gmail.com>
To: computersforpeace@gmail.com, dwmw2@infradead.org,
boris.brezillon@free-electrons.com
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
karlzhang@micron.com, beanhuo@micron.com,
xuejiancheng@huawei.com, Peter Pan <peterpandong@micron.com>
Subject: [PATCH 02/11] mtd: nand_bbt: introduce BBT related data structure
Date: Mon, 14 Mar 2016 02:47:55 +0000 [thread overview]
Message-ID: <1457923684-13505-3-git-send-email-peterpandong@micron.com> (raw)
In-Reply-To: <1457923684-13505-1-git-send-email-peterpandong@micron.com>
From: Brian Norris <computersforpeace@gmail.com>
Currently nand_bbt.c is tied with struct nand_chip, and it makes other
NAND family chips hard to use nand_bbt.c. Maybe it's the reason why
onenand has own bbt(onenand_bbt.c).
Separate struct nand_chip from BBT code can make current BBT shareable.
We create struct nand_bbt to take place of nand_chip in nand_bbt.c
Below is mtd folder structure we want:
drivers/mtd/nand/<all-nand-core-code>
drivers/mtd/nand/raw/<raw-nand-controller-drivers>
drivers/mtd/nand/spi/<spi-nand-code>
drivers/mtd/nand/onenand/<onenand-code>
drivers/mtd/nand/chips/<manufacturer-spcific-code>
Of course, nand_bbt.c should be part of <all-nand-core-code>.
We put every chip layout related information BBT needed into struct
nand_chip_layout_info.
@numchips: number of physical chips, required for NAND_BBT_PERCHIP
@chipsize: the size of one chip for multichip arrays
@chip_shift: number of address bits in one chip
@bbt_erase_shift: number of address bits in a bbt entry
@page_shift: number of address bits in a page
We defined a struct nand_bbt_ops for BBT ops. Struct
@is_bad_bbm: check if a block is factory bad block
@erase: erase block bypassing resvered checks
Struct nand_bbt includes all BBT information:
@mtd: pointer to MTD device structure
@bbt_options: bad block specific options. All options used
here must come from nand_bbt.h.
@bbt_ops: struct nand_bbt_ops pointer.
@info: struct nand_chip_layout_info pointer.
@bbt_td: bad block table descriptor for flash lookup.
@bbt_md: bad block table mirror descriptor
@bbt: bad block table pointer
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
[Peter: 1. correct comment style
2. introduce struct nand_bbt_ops and nand_chip_layout_info]
Signed-off-by: Peter Pan <peterpandong@micron.com>
---
include/linux/mtd/nand_bbt.h | 67 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/include/linux/mtd/nand_bbt.h b/include/linux/mtd/nand_bbt.h
index 5a65230..cfb22c8 100644
--- a/include/linux/mtd/nand_bbt.h
+++ b/include/linux/mtd/nand_bbt.h
@@ -18,6 +18,8 @@
#ifndef __LINUX_MTD_NAND_BBT_H
#define __LINUX_MTD_NAND_BBT_H
+struct mtd_info;
+
/* The maximum number of NAND chips in an array */
#define NAND_MAX_CHIPS 8
@@ -115,4 +117,69 @@ struct nand_bbt_descr {
/* The maximum number of blocks to scan for a bbt */
#define NAND_BBT_SCAN_MAXBLOCKS 4
+struct nand_bbt;
+
+/**
+ * struct nand_bbt_ops - bad block table operations
+ * @is_bad_bbm: check if a block is factory bad block
+ * @erase: erase block bypassing resvered checks
+ */
+struct nand_bbt_ops {
+ /*
+ * This is important to abstract out of nand_bbt.c and provide
+ * separately in nand_base.c and spi-nand-base.c -- it's sort of
+ * duplicated in nand_block_bad() (nand_base) and
+ * scan_block_fast() (nand_bbt) right now
+ *
+ * Note that this also means nand_chip.badblock_pattern should
+ * be removed from nand_bbt.c
+ */
+ int (*is_bad_bbm)(struct mtd_info *mtd, loff_t ofs);
+
+ /* Erase a block, bypassing reserved checks */
+ int (*erase)(struct mtd_info *mtd, loff_t ofs);
+};
+
+/**
+ * struct nand_chip_layout_info - strucure contains all chip layout
+ * information that BBT needed.
+ * @numchips: number of physical chips, required for NAND_BBT_PERCHIP
+ * @chipsize: the size of one chip for multichip arrays
+ * @chip_shift: number of address bits in one chip
+ * @bbt_erase_shift: number of address bits in a bbt entry
+ * @page_shift: number of address bits in a page
+ */
+struct nand_chip_layout_info {
+ int numchips;
+ u64 chipsize;
+ int chip_shift;
+ int bbt_erase_shift;
+ int page_shift;
+};
+
+/**
+ * struct nand_bbt - bad block table structure
+ * @mtd: pointer to MTD device structure
+ * @bbt_options: bad block specific options. All options used
+ * here must come from nand_bbt.h.
+ * @bbt_ops: struct nand_bbt_ops pointer.
+ * @info: struct nand_chip_layout_info pointer.
+ * @bbt_td: bad block table descriptor for flash lookup.
+ * @bbt_md: bad block table mirror descriptor
+ * @bbt: bad block table pointer
+ */
+struct nand_bbt {
+ struct mtd_info *mtd;
+ unsigned int bbt_options;
+ const struct nand_bbt_ops *bbt_ops;
+ struct nand_chip_layout_info *info;
+ /*
+ * Discourage new custom usages here; suggest usage of the
+ * relevant NAND_BBT_* options instead
+ */
+ struct nand_bbt_descr *bbt_td;
+ struct nand_bbt_descr *bbt_md;
+ u8 *bbt;
+};
+
#endif /* __LINUX_MTD_NAND_BBT_H */
--
1.9.1
next prev parent reply other threads:[~2016-03-14 2:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 2:47 [PATCH 00/11] mtd: nand_bbt: introduce independent nand BBT Peter Pan
2016-03-14 2:47 ` [PATCH 01/11] mtd: nand_bbt: new header for nand family BBT Peter Pan
2016-03-14 2:47 ` Peter Pan [this message]
2016-03-25 8:35 ` [PATCH 02/11] mtd: nand_bbt: introduce BBT related data structure Boris Brezillon
2016-03-28 8:09 ` Peter Pan
2016-03-29 8:16 ` Boris Brezillon
2016-04-18 6:22 ` Peter Pan
2016-04-18 7:44 ` Boris Brezillon
2016-04-19 0:40 ` Peter Pan
2016-04-19 7:34 ` Boris Brezillon
2016-05-04 1:36 ` Peter Pan
2016-05-04 20:33 ` Boris Brezillon
2016-05-17 1:03 ` Peter Pan
2016-06-17 2:38 ` Peter Pan
2016-06-21 13:27 ` Boris Brezillon
2016-03-14 2:47 ` [PATCH 03/11] mtd: nand_bbt: add new API definitions Peter Pan
2016-03-14 3:47 ` kbuild test robot
2016-03-25 8:49 ` Boris Brezillon
2016-03-28 7:56 ` Peter Pan
2016-03-14 2:47 ` [PATCH 04/11] mtd: nand_bbt: add nand_bbt_markbad_factory() interface Peter Pan
2016-03-14 2:47 ` [PATCH 05/11] mtd: nand: use new BBT API instead of old ones Peter Pan
2016-03-25 8:51 ` Boris Brezillon
2016-03-28 8:12 ` Peter Pan
2016-03-29 8:07 ` Boris Brezillon
2016-03-14 2:47 ` [PATCH 06/11] mtd: nand_bbt: use struct nand_bbt_ops in BBT Peter Pan
2016-03-14 2:48 ` [PATCH 07/11] mtd: nand: make nand_erase_nand() static Peter Pan
2016-03-14 2:48 ` [PATCH 08/11] mtd: nand_bbt: remove struct nand_chip from nand_bbt.c Peter Pan
2016-03-14 2:48 ` [PATCH 09/11] mtd: nand_bbt: remove old API definitions Peter Pan
2016-03-14 2:48 ` [PATCH 10/11] mtd: nand_bbt: remove NAND_BBT_DYNAMICSTRUCT macro Peter Pan
2016-03-14 2:48 ` [PATCH 11/11] mtd: nand: remove nand_chip.bbt Peter Pan
2016-03-14 2:57 ` [PATCH 00/11] mtd: nand_bbt: introduce independent nand BBT Peter Pan
2016-03-16 12:57 ` Boris Brezillon
2016-03-23 20:57 ` Ezequiel Garcia
2016-03-28 8:20 ` Peter Pan
2016-03-29 8:02 ` Boris Brezillon
2016-03-25 8:50 ` Boris Brezillon
2016-03-28 7:56 ` Peter Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457923684-13505-3-git-send-email-peterpandong@micron.com \
--to=peterpansjtu@gmail.com \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=karlzhang@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=peterpandong@micron.com \
--cc=xuejiancheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®