From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbcCNSfB (ORCPT ); Mon, 14 Mar 2016 14:35:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:27388 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbcCNSe6 (ORCPT ); Mon, 14 Mar 2016 14:34:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,336,1455004800"; d="scan'208";a="66181247" From: Jarkko Sakkinen To: Peter Huewe Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Jarkko Sakkinen Subject: [PATCH] tpm, tpm_crb: remove wmb()'s Date: Mon, 14 Mar 2016 20:34:46 +0200 Message-Id: <1457980486-29229-1-git-send-email-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.7.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wmbs are not neded as we use iowrite32(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index a12b319..1cabe30 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -153,9 +153,6 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t len) memcpy_toio(priv->cmd, buf, len); - /* Make sure that cmd is populated before issuing start. */ - wmb(); - if (priv->flags & CRB_FL_CRB_START) iowrite32(cpu_to_le32(CRB_START_INVOKE), &priv->cca->start); @@ -171,9 +168,6 @@ static void crb_cancel(struct tpm_chip *chip) iowrite32(cpu_to_le32(CRB_CANCEL_INVOKE), &priv->cca->cancel); - /* Make sure that cmd is populated before issuing cancel. */ - wmb(); - if ((priv->flags & CRB_FL_ACPI_START) && crb_do_acpi_start(chip)) dev_err(&chip->dev, "ACPI Start failed\n"); -- 2.7.0