From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932254AbcCNXIo (ORCPT ); Mon, 14 Mar 2016 19:08:44 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:64775 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbcCNXIj (ORCPT ); Mon, 14 Mar 2016 19:08:39 -0400 From: Arnd Bergmann To: Jaegeuk Kim , Changman Lee Cc: Arnd Bergmann , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] f2fs: add missing argument to f2fs_setxattr stub Date: Tue, 15 Mar 2016 00:07:56 +0100 Message-Id: <1457996891-1968923-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:nyakOS9X+c7hi3j06gVI028Zhg/ciR9H9nRz3dnqmyRORhQKo8s 4gQCmyxAgFh7RUOvvRIRTP8TcrhiimQp/VjoLpRPz4QGJKgyhzUGueaaAQ0O0fwMERAH0vQ 5b+GDjaQFvf5CJm5Ka+sLQzuDD6ZZYKKE8UcfCvleel1rFaOzirRLzcs/y/XpUSH33xic0h qrxl6xTYYK5/SdFcmVBxQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:S3oXBSDkvuc=:/tz0jwTPFRtfevMSpTa3qk /rARAcHkH5XTMu1fYtNTHMZFcq0wM4sWsLH0seCjTaCJvGLPQDCXSowD4vd03Ka+y6Hdfe8/r NrF6ZnrMrLaZ8YTcnbi6ZiNIhn0+8nJbAI6SxkQFAGYR1+ZqegRKMYbS7x5p8df1tc4YWEymF C+DVGjFgAXOWbD+Ml1LeXxoukRAHUhhcG9y45iNiJ7nD9BY5SyLls4TcNQIBwXnWF3Sr+Dn0j ErXqj1XqQgLq4Eo2T2/hIK4OH3d15yucwos15Zgj6+ybiavt3LACz9hO3SzTDhz/tArU/Tjp4 XN5PWXJB4rOMr07XCBvciOQ7Y+vM45O0YsPmBu1Cv9g7rCRR6Zj4pOgrRC21mRg6H2VD5q0yE C9dGnz2GLa1oIlhDpWz8TDAJSqXG/tES5eJY3YN8sLP7+oEqhan+HHCF2q5EgPplZid5wQ7Tv A1RywLhyasAnZnhL0o+XiYFXH4U4Lv7IVp0rhuT/DwvTWanwbz7yxpIpRWi4YhGzxAukWXT0b y5LHg42//4AJXj7fSyucaImcF1Rg6w9adYWdfYolP85QtPG74IyIvyVwyBxcfv/HdAzro22+P t+w5TTLunqN4JVfLAftnp49G41NJyF7k03rzUnsFm8D0TxS+pI2Q0MgRJ2HmHiboNWO9JHYiG iyiK/S3KnH/L/JyyT5qnd+TBiuB8cImMhWdjrKRxn03VLGVVPJj8bmGPt6tE+DVhWP+o= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The f2fs_setxattr() prototype for CONFIG_F2FS_FS_XATTR=n has been wrong for a long time, since 8ae8f1627f39 ("f2fs: support xattr security labels"), but there have never been any callers, so it did not matter. Now, the function gets called from f2fs_ioc_keyctl(), which causes a build failure: fs/f2fs/file.c: In function 'f2fs_ioc_keyctl': include/linux/stddef.h:7:14: error: passing argument 6 of 'f2fs_setxattr' makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ fs/f2fs/file.c:1599:27: note: in expansion of macro 'NULL' value, F2FS_KEY_SIZE, NULL, type); ^ In file included from ../fs/f2fs/file.c:29:0: fs/f2fs/xattr.h:129:19: note: expected 'int' but argument is of type 'void *' static inline int f2fs_setxattr(struct inode *inode, int index, ^ fs/f2fs/file.c:1597:9: error: too many arguments to function 'f2fs_setxattr' return f2fs_setxattr(inode, F2FS_XATTR_INDEX_KEY, ^ In file included from ../fs/f2fs/file.c:29:0: fs/f2fs/xattr.h:129:19: note: declared here static inline int f2fs_setxattr(struct inode *inode, int index, Thsi changes the prototype of the empty stub function to match that of the actual implementation. This will not make the key management work when F2FS_FS_XATTR is disabled, but it gets it to build at least. Signed-off-by: Arnd Bergmann Fixes: 1448eee67def ("f2fs: support access control via key management") --- fs/f2fs/xattr.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/xattr.h b/fs/f2fs/xattr.h index cb5282c9ce44..2f4908425d13 100644 --- a/fs/f2fs/xattr.h +++ b/fs/f2fs/xattr.h @@ -127,7 +127,8 @@ extern ssize_t f2fs_listxattr(struct dentry *, char *, size_t); #define f2fs_xattr_handlers NULL static inline int f2fs_setxattr(struct inode *inode, int index, - const char *name, const void *value, size_t size, int flags) + const char *name, const void *value, size_t size, + struct page *page, int flags) { return -EOPNOTSUPP; } -- 2.7.0