From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934879AbcCOSBU (ORCPT ); Tue, 15 Mar 2016 14:01:20 -0400 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:50402 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750934AbcCOSBT (ORCPT ); Tue, 15 Mar 2016 14:01:19 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1560:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3866:3874:4321:5007:6261:10004:10400:10848:11658:11914:12517:12519:12740:13069:13311:13357:13439:14659:21080:30045:30054:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: beast03_7f3a4c831e520 X-Filterd-Recvd-Size: 1143 Message-ID: <1458064872.11972.195.camel@perches.com> Subject: Re: [PATCH] iommu/vt-d: Ratelimit fault handler From: Joe Perches To: Alex Williamson , iommu@lists.linux-foundation.org, dwmw2@infradead.org Cc: joro@8bytes.org, linux-kernel@vger.kernel.org Date: Tue, 15 Mar 2016 11:01:12 -0700 In-Reply-To: <1458061851.11972.193.camel@perches.com> References: <20160315163503.2875.49980.stgit@gimli.home> <1458061851.11972.193.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-15 at 10:10 -0700, Joe Perches wrote: > o Use a single ratelimit state. [] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c [] > + if (__ratelimit(&rs)) > + return 0; That of course should be: if (!__ratelimit(&rs)) return 0;