mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Michal Marek <mmarek@suse.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] kconfig: add unexpected data itself to warning
Date: Wed, 16 Mar 2016 11:53:39 +0100	[thread overview]
Message-ID: <1458125619-28093-2-git-send-email-pebolle@tiscali.nl> (raw)
In-Reply-To: <1458125619-28093-1-git-send-email-pebolle@tiscali.nl>

If the .config parser runs into unexpected data it emits a warnings like
    .config:6911:warning: unexpected data

Add the unexpected data itself to the warning too, to make it easier to
discover what is going wrong:
     .config:6911:warning: unexpected data: CONFOG_CHARGER_TPS65217=m

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 scripts/kconfig/confdata.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 51904c423411..62df2594bc24 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -398,8 +398,12 @@ load:
 			if (conf_set_sym_val(sym, def, def_flags, p))
 				continue;
 		} else {
-			if (line[0] != '\r' && line[0] != '\n')
-				conf_warning("unexpected data");
+			if (line[0] != '\r' && line[0] != '\n') {
+				char *tmp = chomp(line);
+
+				conf_warning("unexpected data: %s", tmp);
+				free(tmp);
+			}
 			continue;
 		}
 setsym:
-- 
2.4.3

  reply	other threads:[~2016-03-16 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 10:53 [PATCH 1/2] kconfig: add chomp like helper function Paul Bolle
2016-03-16 10:53 ` Paul Bolle [this message]
2016-03-16 11:42 ` Michal Marek
2016-03-16 12:41   ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458125619-28093-2-git-send-email-pebolle@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®