From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935168AbcCPPVq (ORCPT ); Wed, 16 Mar 2016 11:21:46 -0400 Received: from mga01.intel.com ([192.55.52.88]:52176 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935099AbcCPPVo (ORCPT ); Wed, 16 Mar 2016 11:21:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,345,1455004800"; d="scan'208";a="765359708" From: Mihai Mihalache To: linux-kernel@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com Cc: yousaf.kaukab@intel.com, hans.holmberg@intel.com, mihai.d.mihalache@intel.com Subject: [PATCH v2] regulator: gpio: check return value of of_get_named_gpio Date: Wed, 16 Mar 2016 08:21:12 -0700 Message-Id: <1458141672-3303-1-git-send-email-mihai.d.mihalache@intel.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At boot time the regulator driver can be initialized before the gpio, in which case the call to of_get_named_gpio will return EPROBE_DEFER. This value is silently passed to regulator_register which will return success, although the gpio is not registered (regulator_ena_gpio_request not called) as the value passed is detected as invalid. The gpio_regulator_probe will therefore succeed win no gpio requested. Signed-off-by: Mihai Mihalache Reviewed-by: Hans Holmberg --- History: V1: - Fix comment from Mark Brown V2: - Explicit check for EPROBE_DEFER for optional property, Mark Brown's feedback. drivers/regulator/gpio-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 464018d..f3147ef 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers/regulator/gpio-regulator.c @@ -162,6 +162,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np, of_property_read_u32(np, "startup-delay-us", &config->startup_delay); config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0); + if (config->enable_gpio == -EPROBE_DEFER) + return ERR_PTR(-EPROBE_DEFER); /* Fetch GPIOs. - optional property*/ ret = of_gpio_count(np); -- 2.1.4