mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: linux-s390@vger.kernel.org
Cc: Eugene Crosser <Eugene.Crosser@ru.ibm.com>,
	linux-kernel@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ursula Braun <ubraun@linux.vnet.ibm.com>,
	ihno@suse.de, mt@suse.com, pwieczorkiewicz@suse.de
Subject: [PATCH] qeth: Default to allow promiscuous mode
Date: Thu, 17 Mar 2016 18:01:25 +0100	[thread overview]
Message-ID: <1458234085-217667-1-git-send-email-agraf@suse.de> (raw)

When a qeth device is in bridge role, one of the ports of an adapter can
ask for promiscuous mode and get it enabled.

The default until now was to not allow user space to enable promiscuous mode
without switching sysfs attributes as well though, diverging from usual
network device semantics.

This patch sets the default to allow promiscuous enablement. That way all
existing tools "just work", albeit only one port of an adapter can be in
promiscuous mode at a given time.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 drivers/s390/net/qeth_l2_sys.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
index 692db49..98c7ac5 100644
--- a/drivers/s390/net/qeth_l2_sys.c
+++ b/drivers/s390/net/qeth_l2_sys.c
@@ -258,6 +258,10 @@ void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card)
 		return;
 	if (!card->options.sbp.supported_funcs)
 		return;
+
+	/* Allow to set promiscuous by default */
+	card->options.sbp.reflect_promisc = 1;
+
 	if (card->options.sbp.role != QETH_SBP_ROLE_NONE) {
 		/* Conditional to avoid spurious error messages */
 		qeth_bridgeport_setrole(card, card->options.sbp.role);
-- 
1.8.5.6

             reply	other threads:[~2016-03-17 17:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 17:01 Alexander Graf [this message]
2016-03-17 17:52 ` Evgeny Cherkashin
     [not found] ` <201603171752.u2HHq7hM025196@d06av11.portsmouth.uk.ibm.com>
2016-03-18  9:36   ` Alexander Graf
2016-03-18 13:07   ` Evgeny Cherkashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458234085-217667-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=Eugene.Crosser@ru.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=ihno@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mt@suse.com \
    --cc=pwieczorkiewicz@suse.de \
    --cc=schwidefsky@de.ibm.com \
    --cc=ubraun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®