mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, hofrat@osadl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: consolidate lock/unlock into unlock_wait
Date: Fri, 18 Mar 2016 15:35:18 -0700	[thread overview]
Message-ID: <1458340518.26915.30.camel@perches.com> (raw)
In-Reply-To: <20160318.173702.788700055531273267.davem@davemloft.net>

On Fri, 2016-03-18 at 17:37 -0400, David Miller wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
> > The spin_lock()/spin_unlock() is synchronizing on the adapter->work_lock
> > as the comment also suggests, which is equivalent to spin_unlock_wait()
> > but the later should be more efficient.
[]
> There really is no justification for this change.
> This is an optimization in a slow-path of the driver.
> The device is a rarely used older piece of hardware.

It really might be nice to take some of the ancient
hardware drivers in drivers/net and move them into
some separate subdirectory like:

	drivers/net/ancient
or
	drivers/net/antiques
or
	drivers/net/archaic
etc...

so there's some clear designation that these crufty
old drivers don't need to be touched anymore except
for maybe when kernel wide changes occur.

  reply	other threads:[~2016-03-18 22:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  9:32 Nicholas Mc Guire
2016-03-18 21:37 ` David Miller
2016-03-18 22:35   ` Joe Perches [this message]
2016-03-19  0:33     ` [RFC net-next 0/2] Create ancient subdirectories for old hardware Joe Perches
2016-03-19  0:33       ` [RFC net-next 1/2] drivers/net: Create an ANCIENT_NETDEVICES symbol Joe Perches
2016-03-19  0:33       ` [RFC net-next 2/2] chelsio: Move original cxgb driver into ancient subdirectory Joe Perches
2016-03-19  2:11       ` [RFC net-next 0/2] Create ancient subdirectories for old hardware David Miller
2016-03-19  2:28         ` Joe Perches
2016-03-19  3:16           ` David Miller
2016-03-19 15:36             ` Joe Perches
2016-03-19  7:24     ` [PATCH] net: consolidate lock/unlock into unlock_wait Nicholas Mc Guire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458340518.26915.30.camel@perches.com \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=hofrat@osadl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®