From: Alex Thorlton <athorlton@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: Alex Thorlton <athorlton@sgi.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Hedi Berriche <hedi@sgi.com>,
x86@kernel.org
Subject: [PATCH 1/2] Disable UV BAU by default
Date: Mon, 21 Mar 2016 12:04:11 -0500 [thread overview]
Message-ID: <1458579852-37580-2-git-send-email-athorlton@sgi.com> (raw)
In-Reply-To: <1458579852-37580-1-git-send-email-athorlton@sgi.com>
For several years, the common practice has been to boot UVs with the
"nobau" parameter on the command line, to disable the BAU. We've
decided that it makes more sense to just disable the BAU by default in
the kernel, and provide the option to turn it on, if desired.
Signed-off-by: Alex Thorlton <athorlton@sgi.com>
Reviewed-by: Hedi Berriche <hedi@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
arch/x86/platform/uv/tlb_uv.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 3b6ec42..a5609a3 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -37,7 +37,7 @@ static int timeout_base_ns[] = {
};
static int timeout_us;
-static int nobau;
+static int nobau = 1;
static int nobau_perm;
static cycles_t congested_cycles;
@@ -106,13 +106,22 @@ static char *stat_description[] = {
"enable: number times use of the BAU was re-enabled"
};
-static int __init
-setup_nobau(char *arg)
+static int __init setup_bau(char *arg)
{
- nobau = 1;
+ if (!arg)
+ return -EINVAL;
+
+ if (!strncmp(arg, "on", 2)) {
+ nobau = 0;
+ pr_info("UV BAU Enabled\n");
+ } else if (!strncmp(arg, "off", 3)) {
+ nobau = 1;
+ pr_info("UV BAU Disabled\n");
+ }
+
return 0;
}
-early_param("nobau", setup_nobau);
+early_param("bau", setup_bau);
/* base pnode in this partition */
static int uv_base_pnode __read_mostly;
--
1.8.5.6
next prev parent reply other threads:[~2016-03-21 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 17:04 [PATCH 0/2] Re-work UV BAU enable/disable logic, add documentation Alex Thorlton
2016-03-21 17:04 ` Alex Thorlton [this message]
2016-03-23 11:27 ` [PATCH 1/2] Disable UV BAU by default Thomas Gleixner
2016-03-23 16:11 ` Alex Thorlton
2016-03-23 17:20 ` Thomas Gleixner
2016-03-23 17:25 ` Alex Thorlton
2016-03-21 17:04 ` [PATCH 2/2] Add documentation for the bau parameter Alex Thorlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458579852-37580-2-git-send-email-athorlton@sgi.com \
--to=athorlton@sgi.com \
--cc=hedi@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®