mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: linux-kernel@vger.kernel.org, srostedt@redhat.com
Cc: peterx@redhat.com
Subject: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf
Date: Tue, 22 Mar 2016 15:40:41 +0800	[thread overview]
Message-ID: <1458632442-6878-2-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1458632442-6878-1-git-send-email-peterx@redhat.com>

This line is useless since we will get more verbose info in
do_connection(). Another problem is, we will get this "connected!" line
everytime after we hit "ctrl-c" for "trace-cmd listen". We possibly do
not want that.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 trace-listen.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/trace-listen.c b/trace-listen.c
index 1e38eda..12cc9c5 100644
--- a/trace-listen.c
+++ b/trace-listen.c
@@ -721,7 +721,6 @@ static void do_accept_loop(int sfd)
 	do {
 		cfd = accept(sfd, (struct sockaddr *)&peer_addr,
 			     &peer_addr_len);
-		printf("connected!\n");
 		if (cfd < 0 && errno == EINTR)
 			continue;
 		if (cfd < 0)
-- 
2.4.3

  reply	other threads:[~2016-03-22  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  7:40 [PATCH trace-cmd 0/2] better error handling during copy Peter Xu
2016-03-22  7:40 ` Peter Xu [this message]
2016-03-22 13:18   ` [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Steven Rostedt
2016-03-23  6:39     ` Peter Xu
2016-03-22  7:40 ` [PATCH trace-cmd 2/2] trace-recorder: better error handling during copy Peter Xu
2016-03-22 13:19   ` Steven Rostedt
2016-03-23  7:02     ` Peter Xu
2016-03-23  7:05     ` [PATCH trace-cmd v2] " Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458632442-6878-2-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome