From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbcCVXkZ (ORCPT ); Tue, 22 Mar 2016 19:40:25 -0400 Received: from smtprelay0010.hostedemail.com ([216.40.44.10]:42413 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750776AbcCVXkW (ORCPT ); Tue, 22 Mar 2016 19:40:22 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3834:3865:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4225:4321:5007:6261:7514:7576:7903:9025:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12048:12262:12438:12517:12519:12555:12679:12740:13069:13311:13357:13439:13845:13894:14181:14659:14721:21080:21365:30054:30056:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: dress13_2da42cd4b65e X-Filterd-Recvd-Size: 2692 Message-ID: <1458690018.22080.5.camel@perches.com> Subject: Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer From: Joe Perches To: Colin King , Patrik Jakobsson , David Airlie , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Dan Carpenter , Alan Cox Date: Tue, 22 Mar 2016 16:40:18 -0700 In-Reply-To: <1458686973-13686-1-git-send-email-colin.king@canonical.com> References: <1458686973-13686-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-22 at 22:49 +0000, Colin King wrote: > From: Colin Ian King > > There is a missing comma between two strings in the dsi_errors[] > array initializer, causing two strings to be concatenated and the > array being incorrectly initialized.  Add in the missing comma. > > Signed-off-by: Colin Ian King > --- >  drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c > index 6b43ae3..1616af2 100644 > --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c > +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c > @@ -72,7 +72,7 @@ static const char *const dsi_errors[] = { >   "RX Prot Violation", >   "HS Generic Write FIFO Full", >   "LP Generic Write FIFO Full", > - "Generic Read Data Avail" > + "Generic Read Data Avail", >   "Special Packet Sent", >   "Tearing Effect", >  }; >>From 2011: https://lkml.org/lkml/2011/7/8/197 and commit fc5ace7ed2a58e32047abf65ff8b5a6432e92fac Author: Dan Carpenter Date:   Fri Jul 8 09:45:19 2011 +0100     Staging: gma500: typo in array initialization          There is a comma missing here between the strings so they were     concatenated by mistake.          Signed-off-by: Dan Carpenter     Signed-off-by: Alan Cox     Signed-off-by: Greg Kroah-Hartman Apparently this wasn't merged back into this version. Are there any other changes in that old staging version that also need to be merged back?