From: Wei Yang <richard.weiyang@gmail.com>
To: treding@nvidia.com, alex.williamson@redhat.com
Cc: joro@8bytes.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [Patch V2 2/2] iommu: remove sysfs_link to device in iommu_group/devices when failed
Date: Wed, 23 Mar 2016 22:25:11 +0000 [thread overview]
Message-ID: <1458771911-30785-3-git-send-email-richard.weiyang@gmail.com> (raw)
In-Reply-To: <1458771911-30785-1-git-send-email-richard.weiyang@gmail.com>
The original code forgets to remove the sysfs_link to a device in
iommu_group/devices directory, when the creation fails or conflicts on the
name.
This patch tries to remove the sysfs_link on the failure.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
drivers/iommu/iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 2696a38..8f480ba 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -403,6 +403,7 @@ rename:
ret = sysfs_create_link_nowarn(group->devices_kobj,
&dev->kobj, device->name);
if (ret) {
+ sysfs_remove_link(group->devices_kobj, device->name);
kfree(device->name);
if (ret == -EEXIST && i >= 0) {
/*
--
1.7.9.5
next prev parent reply other threads:[~2016-03-23 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 22:25 [Patch V2 0/2] Cleanup on IOMMU Wei Yang
2016-03-23 22:25 ` [Patch V2 1/2] iommu: remove the iommu_callback_data Wei Yang
2016-04-14 13:59 ` Wei Yang
2016-03-23 22:25 ` Wei Yang [this message]
2016-03-23 23:04 ` [Patch V2 2/2] iommu: remove sysfs_link to device in iommu_group/devices when failed Alex Williamson
2016-03-24 14:51 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458771911-30785-3-git-send-email-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®