From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbcC0TPC (ORCPT ); Sun, 27 Mar 2016 15:15:02 -0400 Received: from mail-ig0-f193.google.com ([209.85.213.193]:36781 "EHLO mail-ig0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcC0TOK (ORCPT ); Sun, 27 Mar 2016 15:14:10 -0400 From: Clifton Barnes To: arnaud.patard@rtp-net.org Cc: kernel-janitors@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Clifton Barnes Subject: [PATCH 4/5] staging: xgifb: fix comparison order Date: Sun, 27 Mar 2016 15:13:02 -0400 Message-Id: <1459105983-17251-4-git-send-email-clifton.a.barnes@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459105983-17251-1-git-send-email-clifton.a.barnes@gmail.com> References: <1459105983-17251-1-git-send-email-clifton.a.barnes@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix checkpatch.pl warning about 'Comparisons should place the constant on the right side of the test' Signed-off-by: Clifton Barnes --- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 50c8ea4..8bf253c 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo); - if (table[i].PANELID == tempdx) { + if (tempdx == table[i].PANELID) { tempbx = table[i].MASK; tempdx = pVBInfo->LCDInfo; @@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const i = 0; while (Tap4TimingPtr[i].DE != 0xFFFF) { - if (Tap4TimingPtr[i].DE == tempax) + if (tempax == Tap4TimingPtr[i].DE) break; i++; } -- 1.9.1