From: Joe Perches <joe@perches.com>
To: "Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Brown, Len" <len.brown@intel.com>
Cc: Lv Zheng <zetalog@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release
Date: Sun, 27 Mar 2016 20:15:54 -0700 [thread overview]
Message-ID: <1459134954.25110.26.camel@perches.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB655F7@SHSMSX101.ccr.corp.intel.com>
On Mon, 2016-03-28 at 03:02 +0000, Zheng, Lv wrote:
> Hi,
Hello.
> > So why not fix the process script first?
> > Maybe add something like:
> > $ grep -E "^typedef\s+\w+\s*\*?\s*acpi_\w+" include/acpi/actypes.h | \
> > grep -Eoh "\bacpi_\w+"
> >
> > to the acpi_types variable in the lindent_single function
> [Lv Zheng]
> I don't think this can work given:
> 1. we are not only dealing with typedefs, but structs, struct xxx will be converted into types during the release process.
> 2. we have only upper cased type names in ACPICA upstream, but have the lower cased type names in Linux, and this doesn't solve that.
> So I guess you didn't test your idea.
Good guess.
The "maybe add something like" should give you a clue.
> You need to pull ACPICA repo and do the followings to confirm if this is working:
No, I disagree. _I_ don't need to. You need to.
You shouldn't have a process that generates defective patches
and then sends them to the list.
cheers, Joe
next prev parent reply other threads:[~2016-03-28 3:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 1:38 [PATCH 00/30] ACPICA: 20160318 Release Lv Zheng
2016-03-24 1:38 ` [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release Lv Zheng
2016-03-24 1:46 ` Joe Perches
2016-03-24 6:19 ` Zheng, Lv
2016-03-24 6:35 ` Brown, Len
2016-03-24 6:53 ` Zheng, Lv
2016-03-24 11:00 ` Joe Perches
2016-03-28 3:02 ` Zheng, Lv
2016-03-28 3:15 ` Joe Perches [this message]
2016-03-29 5:37 ` Zheng, Lv
2016-03-29 5:56 ` Joe Perches
2016-03-24 1:38 ` [PATCH 02/30] ACPICA: Linuxize: Remove useless platform headers Lv Zheng
2016-03-24 1:38 ` [PATCH 03/30] ACPICA: Headers: Add new constants for the DBG2 ACPI table Lv Zheng
2016-03-24 1:38 ` [PATCH 04/30] ACPICA: Headers: Minor update for SPCR " Lv Zheng
2016-03-24 1:38 ` [PATCH 05/30] ACPICA: ACPI 6.1: Updates for the HEST " Lv Zheng
2016-03-24 1:39 ` [PATCH 06/30] ACPICA: IORT: Add in support for the SMMUv3 subtable Lv Zheng
2016-03-24 1:39 ` [PATCH 07/30] ACPICA: ACPI 6.1: Update NFIT table for additional new fields Lv Zheng
2016-03-24 1:39 ` [PATCH 08/30] ACPICA: Headers: Update DMAR table for October 2014 I/O spec Lv Zheng
2016-03-24 1:39 ` [PATCH 09/30] ACPICA: Tables: Update FADT handling Lv Zheng
2016-03-24 1:39 ` [PATCH 10/30] ACPICA: ACPI 6.1: Add full support for this version of ACPI spec Lv Zheng
2016-03-24 1:39 ` [PATCH 11/30] ACPICA: iASL/Headers: Fix incorrect definition of FPDT table Lv Zheng
2016-03-24 1:39 ` [PATCH 12/30] ACPICA: Intepreter: Add object extensions to Concatenate operand Lv Zheng
2016-03-24 1:39 ` [PATCH 13/30] ACPICA: Interpreter: Update some function headers, no functional change Lv Zheng
2016-03-24 1:40 ` [PATCH 14/30] ACPICA: iASL: Cleanup/optimization for ToPLD macro support Lv Zheng
2016-03-24 1:40 ` [PATCH 15/30] ACPICA: Cleanup some invocation indentations, no functional change Lv Zheng
2016-03-24 1:40 ` [PATCH 16/30] ACPICA: Headers: Update generation of the ACPICA library Lv Zheng
2016-03-24 1:40 ` [PATCH 17/30] ACPICA: Add support for QNX 6.6 platform Lv Zheng
2016-03-24 1:40 ` [PATCH 18/30] ACPICA: Utilities: Update for strtoul64 merger Lv Zheng
2016-03-24 1:40 ` [PATCH 19/30] ACPICA: All: const keyword changes across the ACPICA source Lv Zheng
2016-03-24 1:40 ` [PATCH 20/30] ACPICA: iASL/Disassembler: Improve handling of unresolved methods Lv Zheng
2016-03-24 1:40 ` [PATCH 21/30] ACPICA: Utilities: Add ACPI_IS_POWER_OF_TWO() Lv Zheng
2016-03-24 1:41 ` [PATCH 22/30] Utilities: Fix missing parentheses in ACPI_GET_BITS()/ACPI_SET_BITS() Lv Zheng
2016-03-24 1:41 ` [PATCH 23/30] ACPICA: Hardware: Enhance acpi_hw_validate_register() with access_width/bit_offset awareness Lv Zheng
2016-03-24 1:41 ` [PATCH 24/30] ACPICA: Hardware: Add access_width/bit_offset support in acpi_hw_read() Lv Zheng
2016-03-29 8:14 ` Zheng, Lv
2016-03-24 1:41 ` [PATCH 25/30] ACPICA: Hardware: Add access_width/bit_offset support for acpi_hw_write() Lv Zheng
2016-03-24 1:41 ` [PATCH 26/30] ACPICA: Interpreter: Fix wrong conditions for acpi_ev_install_region_handlers() invocation Lv Zheng
2016-03-24 1:41 ` [PATCH 27/30] ACPICA: Tables: Fix wrong MLC condition for dynamic table loading Lv Zheng
2016-03-24 1:41 ` [PATCH 28/30] ACPICA: Events: Fix an issue that _REG association can happen before namespace is initialized Lv Zheng
2016-03-24 1:41 ` [PATCH 29/30] ACPICA: Namespace: Reorder \_SB._INI to make sure it is evaluated before _REG evaluations Lv Zheng
2016-03-24 1:42 ` [PATCH 30/30] ACPICA: Update version to 20160318 Lv Zheng
2016-03-24 13:08 ` [PATCH 00/30] ACPICA: 20160318 Release Rafael J. Wysocki
2016-03-28 3:03 ` Zheng, Lv
2016-07-11 14:38 ` Matthias Brugger
2016-07-11 14:48 ` Rafael J. Wysocki
2016-07-11 14:48 ` Matthias Brugger
2016-07-11 14:54 ` Rafael J. Wysocki
2016-07-11 15:20 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459134954.25110.26.camel@perches.com \
--to=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome