From: Daniel Wagner <wagi@monom.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
Jiri Kosina <jkosina@suse.cz>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH v2] scripts/gdb: Fix loading of modules information
Date: Tue, 29 Mar 2016 08:58:25 +0200 [thread overview]
Message-ID: <1459234705-8668-1-git-send-email-wagi@monom.org> (raw)
In-Reply-To: <1459233699-5541-1-git-send-email-wagi@monom.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
The module_core symbols is not available due to
7523e4dc5057 ("module: use a structure to encapsulate layout.")
The base address of the module is now stored inside
struct module_layout.
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
Obviously, it's too early to send patches. This times it even works.
scripts/gdb/linux/modules.py | 3 ++-
scripts/gdb/linux/symbols.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/gdb/linux/modules.py b/scripts/gdb/linux/modules.py
index 25db8cf..a1ec0f3 100644
--- a/scripts/gdb/linux/modules.py
+++ b/scripts/gdb/linux/modules.py
@@ -73,8 +73,9 @@ class LxLsmod(gdb.Command):
" " if utils.get_long_type().sizeof == 8 else ""))
for module in module_list():
+ module_layout=module['core_layout']
gdb.write("{address} {name:<19} {size:>8} {ref}".format(
- address=str(module['module_core']).split()[0],
+ address=str(module_layout['base']),
name=module['name'].string(),
size=str(module['core_size']),
ref=str(module['refcnt']['counter'])))
diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
index 627750c..8650ede 100644
--- a/scripts/gdb/linux/symbols.py
+++ b/scripts/gdb/linux/symbols.py
@@ -108,7 +108,8 @@ lx-symbols command."""
def load_module_symbols(self, module):
module_name = module['name'].string()
- module_addr = str(module['module_core']).split()[0]
+ module_layout = module['core_layout']
+ module_addr = str(module_layout['base'])
module_file = self._get_module_file(module_name)
if not module_file and not self.module_files_updated:
--
2.5.5
next prev parent reply other threads:[~2016-03-29 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 6:41 [PATCH] " Daniel Wagner
2016-03-29 6:58 ` Daniel Wagner [this message]
2016-03-29 6:59 ` Jan Kiszka
2016-03-29 7:13 ` Daniel Wagner
2016-03-29 7:22 ` Jan Kiszka
2016-03-31 6:17 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459234705-8668-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=jan.kiszka@siemens.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®