mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca Abeni <luca.abeni@unitn.it>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
	Luca Abeni <luca.abeni@unitn.it>
Subject: [RFC v2 7/7] Do not reclaim the whole CPU bandwidth
Date: Fri,  1 Apr 2016 17:12:33 +0200	[thread overview]
Message-ID: <1459523553-29089-8-git-send-email-luca.abeni@unitn.it> (raw)
In-Reply-To: <1459523553-29089-1-git-send-email-luca.abeni@unitn.it>

Original GRUB tends to reclaim 100% of the CPU time... And this allows a
CPU hot to starve non-deadline tasks.
To address this issue, allow the scheduler to reclaim only a specified
fraction of CPU time.

Signed-off-by: Luca Abeni <luca.abeni@unitn.it>
---
 kernel/sched/core.c     | 4 ++++
 kernel/sched/deadline.c | 7 ++++++-
 kernel/sched/sched.h    | 6 ++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3224132..b22fe83 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7941,6 +7941,10 @@ static void sched_dl_do_global(void)
 		raw_spin_unlock_irqrestore(&dl_b->lock, flags);
 
 		rcu_read_unlock_sched();
+		if (dl_b->bw == -1)
+			cpu_rq(cpu)->dl.non_deadline_bw = 0;
+		else
+			cpu_rq(cpu)->dl.non_deadline_bw = (1 << 20) - new_bw;
 	}
 }
 
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index b56f76f..b6ecec2 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -154,6 +154,11 @@ void init_dl_rq(struct dl_rq *dl_rq)
 #else
 	init_dl_bw(&dl_rq->dl_bw);
 #endif
+	if (global_rt_runtime() == RUNTIME_INF)
+		dl_rq->non_deadline_bw = 0;
+	else
+		dl_rq->non_deadline_bw = (1 << 20) -
+			to_ratio(global_rt_period(), global_rt_runtime());
 }
 
 #ifdef CONFIG_SMP
@@ -792,7 +797,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
  */
 u64 grub_reclaim(u64 delta, struct rq *rq)
 {
-	return (delta * rq->dl.running_bw) >> 20;
+	return (delta * (rq->dl.non_deadline_bw + rq->dl.running_bw)) >> 20;
 }
 
 /*
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 22d36b2..9fb3413 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -526,6 +526,12 @@ struct dl_rq {
 	 * task blocks
 	 */
 	s64 running_bw;
+
+	/*
+	 * Fraction of the CPU utilization that cannot be reclaimed
+	 * by the GRUB algorithm.
+	 */
+	s64 non_deadline_bw;
 };
 
 #ifdef CONFIG_SMP
-- 
2.5.0

      parent reply	other threads:[~2016-04-01 15:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 15:12 [RFC v2 0/7] CPU reclaiming for SCHED_DEADLINE Luca Abeni
2016-04-01 15:12 ` [RFC v2 1/7] Track the active utilisation Luca Abeni
2016-04-05 12:23   ` Peter Zijlstra
2016-04-05 16:47     ` luca abeni
2016-04-01 15:12 ` [RFC v2 2/7] Correctly track the active utilisation for migrating tasks Luca Abeni
2016-04-05 12:24   ` Peter Zijlstra
2016-04-05 16:50     ` luca abeni
2016-04-01 15:12 ` [RFC v2 3/7] Improve the tracking of active utilisation Luca Abeni
2016-04-05 12:42   ` Peter Zijlstra
2016-04-05 17:00     ` luca abeni
2016-04-05 12:42   ` Peter Zijlstra
2016-04-05 17:05     ` luca abeni
2016-04-05 14:48   ` Peter Zijlstra
2016-04-05 17:17     ` luca abeni
2016-04-05 15:00   ` Peter Zijlstra
2016-04-05 17:56     ` luca abeni
2016-04-05 18:00       ` Peter Zijlstra
2016-04-05 19:35         ` luca abeni
2016-04-05 18:02       ` Peter Zijlstra
2016-04-05 19:24         ` luca abeni
2016-04-05 19:31           ` Peter Zijlstra
2016-04-05 19:32           ` luca abeni
2016-04-05 18:11       ` Peter Zijlstra
2016-04-01 15:12 ` [RFC v2 4/7] Fix the update of the total -deadline utilization Luca Abeni
2016-04-05 12:58   ` Peter Zijlstra
2016-04-05 17:16     ` luca abeni
2016-04-01 15:12 ` [RFC v2 5/7] GRUB accounting Luca Abeni
2016-04-01 15:12 ` [RFC v2 6/7] Make GRUB a task's flag Luca Abeni
2016-04-01 15:12 ` Luca Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459523553-29089-8-git-send-email-luca.abeni@unitn.it \
    --to=luca.abeni@unitn.it \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®